aboutsummaryrefslogtreecommitdiffstats
path: root/package/firewall/files/lib
diff options
context:
space:
mode:
authorJo-Philipp Wich <jow@openwrt.org>2011-07-26 22:21:39 +0000
committerJo-Philipp Wich <jow@openwrt.org>2011-07-26 22:21:39 +0000
commit7a206885df21867df25e02199be083290927d6b7 (patch)
treed48428bd7a8e586901b3dca156f94dff63c01e6a /package/firewall/files/lib
parentd6431df9c1c19e5b1f4f387e36c8f1825bce3b8f (diff)
downloadupstream-7a206885df21867df25e02199be083290927d6b7.tar.gz
upstream-7a206885df21867df25e02199be083290927d6b7.tar.bz2
upstream-7a206885df21867df25e02199be083290927d6b7.zip
firewall: prevent redundant rules if multiple ports and multiple icmp types are given in a rule block for both icmp and other protocols
SVN-Revision: 27792
Diffstat (limited to 'package/firewall/files/lib')
-rw-r--r--package/firewall/files/lib/core_rule.sh23
1 files changed, 16 insertions, 7 deletions
diff --git a/package/firewall/files/lib/core_rule.sh b/package/firewall/files/lib/core_rule.sh
index 0a25fcd953..de8cd8ea35 100644
--- a/package/firewall/files/lib/core_rule.sh
+++ b/package/firewall/files/lib/core_rule.sh
@@ -67,21 +67,30 @@ fw_load_rule() {
[ "$rule_proto" == "tcpudp" ] && rule_proto="tcp udp"
local pr; for pr in $rule_proto; do
+ local sports dports itypes
+ case "$pr" in
+ icmp|icmpv6|1|58)
+ sports=""; dports=""
+ itypes="$rule_icmp_type"
+ ;;
+ *)
+ sports="$rule_src_port"
+ dports="$rule_dest_port"
+ itypes=""
+ ;;
+ esac
+
fw_get_negation pr '-p' "$pr"
- local sp; for sp in ${rule_src_port:-""}; do
+ local sp; for sp in ${sports:-""}; do
fw_get_port_range sp $sp
fw_get_negation sp '--sport' "$sp"
- local dp; for dp in ${rule_dest_port:-""}; do
+ local dp; for dp in ${dports:-""}; do
fw_get_port_range dp $dp
fw_get_negation dp '--dport' "$dp"
local sm; for sm in ${rule_src_mac:-""}; do
fw_get_negation sm '--mac-source' "$sm"
- local it; for it in ${rule_icmp_type:-""}; do
+ local it; for it in ${itypes:-""}; do
fw_get_negation it '--icmp-type' "$it"
- case "$pr" in
- *" icmp"|*" icmpv6"|*" 1"|*" 58") sp=""; dp="" ;;
- *) it="" ;;
- esac
fw add $mode $table $chain $target + \
{ $rule_src_ip $rule_dest_ip } { \
$src_spec $dest_spec \