aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHenrique de Moraes Holschuh <henrique@nic.br>2019-11-01 08:56:50 -0300
committerPetr Štetiar <ynezz@true.cz>2019-11-07 22:51:37 +0100
commit8eab0a003629d0b60563df5f9eaa973969bbc763 (patch)
tree65b1845664bd7cdad3935c4d048567fab8ccba76
parentad7c6102f2098c3dc8233e4590ac47753dc4900d (diff)
downloadupstream-8eab0a003629d0b60563df5f9eaa973969bbc763.tar.gz
upstream-8eab0a003629d0b60563df5f9eaa973969bbc763.tar.bz2
upstream-8eab0a003629d0b60563df5f9eaa973969bbc763.zip
busybox: disable default config option FEATURE_SUID=y
Commit ad7c6102f209 ("busybox: fix missing install with suid bit set if FEATURE_SUID=y") actually fixes BUSYBOX_CONFIG_FEATURE_SUID option and thus would install busybox setuid root by default which would result in possibly unwanted change of current behaviour, so let's disable this option by default in order to preserve the current status-quo. For the record: disabling FEATURE_SUID to preserve the status-quo does *not* imply the current status-quo is "safer", or for that matter, in any way desireable. That is a discussion to be had on the mailing lists. Switching the FEATURE_SUID default to "n" is simply a compromise to facilitate the merge of the changes that unbreak FEATURE_SUID. Ref: PR#2502 Signed-off-by: Henrique de Moraes Holschuh <henrique@nic.br> [commit title/description facelift] Signed-off-by: Petr Štetiar <ynezz@true.cz>
-rw-r--r--package/utils/busybox/Config-defaults.in2
1 files changed, 1 insertions, 1 deletions
diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
index 37238f05c3..c0aaecbb30 100644
--- a/package/utils/busybox/Config-defaults.in
+++ b/package/utils/busybox/Config-defaults.in
@@ -60,7 +60,7 @@ config BUSYBOX_DEFAULT_INSTALL_NO_USR
default n
config BUSYBOX_DEFAULT_FEATURE_SUID
bool
- default y
+ default n
config BUSYBOX_DEFAULT_FEATURE_SUID_CONFIG
bool
default n