diff options
| author | John Crispin <blogic@openwrt.org> | 2014-08-25 06:35:50 +0000 |
|---|---|---|
| committer | John Crispin <blogic@openwrt.org> | 2014-08-25 06:35:50 +0000 |
| commit | e723b7928ac7f10adddcb6986930a4c0f8a7ac79 (patch) | |
| tree | 9fdfe0ac58abb317b80df55e8715c220fd5b6d0c /package/network/config/firewall | |
| parent | 6c505b7533f02bcf1baf9d00d2b885cb778b5d1a (diff) | |
| download | master-187ad058-e723b7928ac7f10adddcb6986930a4c0f8a7ac79.tar.gz master-187ad058-e723b7928ac7f10adddcb6986930a4c0f8a7ac79.tar.bz2 master-187ad058-e723b7928ac7f10adddcb6986930a4c0f8a7ac79.zip | |
package/*: remove useless explicit set of function returncode
somebody started to set a function returncode in the validation
stuff and everybody copies it, e.g.
myfunction()
{
fire_command
return $?
}
a function automatically returns with the last returncode,
so we can safely remove the command 'return $?'. reference:
http://tldp.org/LDP/abs/html/exit-status.html
"The last command executed in the function or script determines the exit status."
Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@42278 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'package/network/config/firewall')
| -rwxr-xr-x | package/network/config/firewall/files/firewall.init | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/package/network/config/firewall/files/firewall.init b/package/network/config/firewall/files/firewall.init index 662dd8010b..ee3ed1a283 100755 --- a/package/network/config/firewall/files/firewall.init +++ b/package/network/config/firewall/files/firewall.init @@ -15,8 +15,6 @@ validate_firewall_redirect() 'dest_ip:cidr' \ 'dest_port:or(port, portrange)' \ 'target:or("SNAT", "DNAT")' - - return $? } validate_firewall_rule() @@ -28,8 +26,6 @@ validate_firewall_rule() 'src_port:or(port, portrange)' \ 'dest_port:or(port, portrange)' \ 'target:string' - - return $? } service_triggers() { |