Add buffer overflow checks to handle truncated and corrupted sis files.

1 files changed, 12 insertions, 5 deletions

diff --git a/sisinstall/sismain.cpp b/sisinstall/sismain.cpp
index 8516b0f..5a5b640 100644
--- a/sisinstall/sismain.cpp
+++ b/sisinstall/sismain.cpp
@@ -67,12 +67,19 @@ void main(int argc, char* argv[])
 		}
 	createCRCTable();
 	SISFile sisFile;
-	sisFile.fillFrom(buf);
-	if (!dryrun)
+	SisRC rc = sisFile.fillFrom(buf, len);
+	if (rc == SIS_OK)
 		{
-		SISInstaller installer;
-		installer.setPsion(psion);
-		installer.run(&sisFile, buf);
+		if (!dryrun)
+			{
+			SISInstaller installer;
+			installer.setPsion(psion);
+			installer.run(&sisFile, buf, len);
+			}
+		}
+	else
+		{
+		printf("Could not parse the sis file.\n");
 		}
 	psion->disconnect();