| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
verilog: significant block scoping improvements
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This change set contains a number of bug fixes and improvements related to
scoping and resolution in generate and procedural blocks. While many of the
frontend changes are interdependent, it may be possible bring the techmap
changes in under a separate PR.
Declarations within unnamed generate blocks previously encountered issues
because the data declarations were left un-prefixed, breaking proper scoping.
The LRM outlines behavior for generating names for unnamed generate blocks. The
original goal was to add this implicit labelling, but doing so exposed a number
of issues downstream. Additional testing highlighted other closely related scope
resolution issues, which have been fixed. This change also adds support for
block item declarations within unnamed blocks in SystemVerilog mode.
1. Unlabled generate blocks are now implicitly named according to the LRM in
`label_genblks`, which is invoked at the beginning of module elaboration
2. The Verilog parser no longer wraps explicitly named generate blocks in a
synthetic unnamed generate block to avoid creating extra hierarchy levels
where they should not exist
3. The techmap phase now allows special control identifiers to be used outside
of the topmost scope, which is necessary because such wires and cells often
appear in unlabeled generate blocks, which now prefix the declarations within
4. Some techlibs required modifications because they relied on the previous
invalid scope resolution behavior
5. `expand_genblock` has been simplified, now only expanding the outermost
scope, completely deferring the inspection and elaboration of nested scopes;
names are now resolved by looking in the innermost scope and stepping outward
6. Loop variables now always become localparams during unrolling, allowing them
to be resolved and shadowed like any other identifier
7. Identifiers in synthetic function call scopes are now prefixed and resolved
in largely the same manner as other blocks
before: `$func$\func_01$tests/simple/scopes.blk.v:60$5$\blk\x`
after: `\func_01$func$tests/simple/scopes.v:60$5.blk.x`
8. Support identifiers referencing a local generate scope nested more
than 1 level deep, i.e. `B.C.x` while within generate scope `A`, or using a
prefix of a current or parent scope, i.e. `B.C.D.x` while in `A.B`, `A.B.C`,
or `A.B.C.D`
9. Variables can now be declared within unnamed blocks in SystemVerilog mode
Addresses the following issues: 656, 2423, 2493
|
|/ / |
|
|\ \
| | |
| | | |
verilog: allow spaces in macro arguments
|
| | | |
|
| | | |
|
|/ / |
|
|/
|
|
|
| |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
| |
|
| |
|
|
|
|
|
|
| |
Fixes #2394
Signed-off-by: Claire Xenia Wolf <claire@symbioticeda.com>
|
|
|
|
| |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
|
|
|
|
| |
Signed-off-by: Claire Wolf <claire@symbioticeda.com>
|
|
|
|
| |
Signed-off-by: Claire Wolf <claire@symbioticeda.com>
|
|
|
|
| |
Signed-off-by: Claire Wolf <claire@symbioticeda.com>
|
|
|
|
| |
Signed-off-by: Claire Wolf <claire@symbioticeda.com>
|
|
|
|
| |
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
|
|
|
|
|
| |
This commit fixes S/R conflicts introduced by commit 6f9be93.
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
|
|
|
|
|
|
| |
This commit fixes R/R conflicts introduced by commit 7e83a51.
Parameter logic is already defined as part of `param_range_type` rule.
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
|
|
|
| |
This reverts commit 9c120b89ace6c111aa4677616947d18d980b9c1a.
|
|
|
|
| |
Fixes #2253.
|
|
|
|
|
|
|
|
| |
This reverts commit 7e83a51fc96495c558a31fc3ca6c1a5ba4764f15.
This reverts commit b422f2e4d0b8d5bfa97913d6b9dee488b59fc405.
This reverts commit 7cb56f34b06de666935fbda315ce7c7bd45048b3.
This reverts commit 6f9be939bd7653b0bdcae93a1033a086a4561b68.
This reverts commit 76a34dc5f3a60c89efeaa3378ca0e2700a8aebd2.
|
|
|
|
| |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
|
|\
| |
| | |
Signed and macro grammar update
|
| |
| |
| |
| | |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit fixes signed/unsigned grammar in parameters as defined in SV
LRM A2.2.1. Example of correct parameters:
parameter integer signed i = 0;
parameter integer unsigned i = 0;
Example of incorrect parameters:
parameter signed integer i = 0;
parameter unsigned integer i = 0;
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
|\ \
| | |
| | | |
Support SystemVerilog Static Cast
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Support SystemVerilog Static Cast
- size
- signedness
- (type is not supposted yet)
Fix #535
|
|\ \
| | |
| | | |
Add logic-assignments operators
|
| | |
| | |
| | |
| | | |
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
| |/
| |
| |
| | |
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
|
| |
| |
| |
| | |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
|
|/
|
|
| |
Signed-off-by: Lukasz Dalek <ldalek@antmicro.com>
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| |\
| | |
| | | |
verilog: Move lexer location variables from global namespace to `VERILOG_FRONTEND` namespace.
|
| | |
| | |
| | |
| | | |
`VERILOG_FRONTEND` namespace.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The chosen value shouldn't have any effect. I considered something
clearly wrong like -1, but there's no checking inside the generated
lexer, and I suspect this will cause even weirder bugs if triggered
than just setting it to INITIAL.
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
... rule which causes a s/r conflict. Now we get an empty genblock,
which should be okay.
|
| | | |
|
| |\ \
| | | |
| | | | |
verilog: support attributes before (not after) task identifier (but 13 s/r conflicts)
|
| | | |
| | | |
| | | | |
Co-authored-by: Alberto Gonzalez <61295559+boqwxp@users.noreply.github.com>
|
| | | | |
|