diff options
| author | Tristan Gingold <tgingold@free.fr> | 2019-08-02 05:46:09 +0200 |
|---|---|---|
| committer | Tristan Gingold <tgingold@free.fr> | 2019-08-02 05:46:46 +0200 |
| commit | 513712dda3230bafb9e08fc5ae549ab84710c097 (patch) | |
| tree | 776d528c967d5504dce3079f81e6c5d9909a0ff4 | |
| parent | 9b64728925b49051e6ae489ae005c0f22df0110e (diff) | |
| download | ghdl-513712dda3230bafb9e08fc5ae549ab84710c097.tar.gz ghdl-513712dda3230bafb9e08fc5ae549ab84710c097.tar.bz2 ghdl-513712dda3230bafb9e08fc5ae549ab84710c097.zip | |
synth: improve error message for multiple assignments.
| -rw-r--r-- | src/synth/synth-environment.adb | 24 |
1 files changed, 20 insertions, 4 deletions
diff --git a/src/synth/synth-environment.adb b/src/synth/synth-environment.adb index 6c23046ea..d6f64e21f 100644 --- a/src/synth/synth-environment.adb +++ b/src/synth/synth-environment.adb @@ -283,6 +283,19 @@ package body Synth.Environment is end Pop_And_Merge_Phi; -- Merge sort of conc_assign by offset. + function Le_Conc_Assign (Left, Right : Conc_Assign) return Boolean is + begin + if Get_Conc_Offset (Left) < Get_Conc_Offset (Right) then + return True; + end if; + if Get_Conc_Offset (Left) = Get_Conc_Offset (Right) then + return (Get_Width (Get_Conc_Value (Left)) + < Get_Width (Get_Conc_Value (Right))); + else + return False; + end if; + end Le_Conc_Assign; + procedure Sort_Conc_Assign (Chain : Conc_Assign; Len : Natural; First : out Conc_Assign; @@ -307,10 +320,11 @@ package body Synth.Environment is First := No_Conc_Assign; Last := No_Conc_Assign; for I in 1 .. Len loop - if Left /= No_Conc_Assign - and then - (Right = No_Conc_Assign - or else Get_Conc_Offset (Left) <= Get_Conc_Offset (Right)) + pragma Assert (not (Left = No_Conc_Assign + and Right = No_Conc_Assign)); + if Right = No_Conc_Assign + or else + (Left /= No_Conc_Assign and then Le_Conc_Assign (Left, Right)) then El := Left; Left := Get_Conc_Chain (Left); @@ -367,6 +381,7 @@ package body Synth.Environment is Last_Asgn := Asgn; Asgn := Get_Conc_Chain (Asgn); elsif Next_Off > Expected_Off then + -- There is an hole. if Next_Off = Expected_Off + 1 then Warning_Msg_Synth (+Wire_Rec.Decl, "no assignment for offset %v", @@ -401,6 +416,7 @@ package body Synth.Environment is (+Next_Off, +(Expected_Off - 1))); -- TODO: insert resolver pragma Assert (Asgn /= No_Conc_Assign); + Expected_Off := Expected_Off + Get_Width (Get_Conc_Value (Asgn)); Last_Asgn := Asgn; Asgn := Get_Conc_Chain (Asgn); end if; |