aboutsummaryrefslogtreecommitdiffstats
path: root/util/manibuilder/Dockerfile.qemu-user-static
diff options
context:
space:
mode:
authorAnastasia Klimchuk <aklm@chromium.org>2021-04-26 15:19:11 +1000
committerNico Huber <nico.h@gmx.de>2021-04-27 10:32:38 +0000
commitcfb5308de307b8770b966fdfc5cc5276dc17fddf (patch)
treed59f5821f915e28cdedcfec308545063fd06b644 /util/manibuilder/Dockerfile.qemu-user-static
parent8baf98d2ea48ee633e81ea990af81bbec82c7a02 (diff)
downloadflashrom-cfb5308de307b8770b966fdfc5cc5276dc17fddf.tar.gz
flashrom-cfb5308de307b8770b966fdfc5cc5276dc17fddf.tar.bz2
flashrom-cfb5308de307b8770b966fdfc5cc5276dc17fddf.zip
mec1308.c: Separate shutdown from failed init cleanup
Shutdown function was covering two different jobs here: 1) the actual shutdown which is run at the end of the driver's lifecycle and 2) cleanup in cases when initialisation failed. Now, shutdown is only doing its main job (#1), and the driver itself is doing cleanup when init fails (#2). The good thing is that now resources are released/closed immediately in cases when init fails (vs shutdown function which was run at some point later), and the driver leaves clean space after itself if init fails. And very importantly this unlocks API change which plans to move register_shutdown inside register master API, see https://review.coreboot.org/c/flashrom/+/51761 TEST=builds and ninja test from 51487 BUG=b:185191942 Change-Id: I6d62d43dd8b6ebc595f9fd747e0f4cd80f3c10da Signed-off-by: Anastasia Klimchuk <aklm@chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/52597 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'util/manibuilder/Dockerfile.qemu-user-static')
0 files changed, 0 insertions, 0 deletions
147'>147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198