diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-06-07 12:33:53 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2021-06-09 16:03:30 +0000 |
| commit | 3bd47524c044168b01e54e772d23c7fa723dc0d5 (patch) | |
| tree | ce8c816c3bb0477afb92ed5a7fc222c68a87057c /pcidev.c | |
| parent | 14c916d3801f0f25913e66a157fc834d76cdffba (diff) | |
| download | flashrom-3bd47524c044168b01e54e772d23c7fa723dc0d5.tar.gz flashrom-3bd47524c044168b01e54e772d23c7fa723dc0d5.tar.bz2 flashrom-3bd47524c044168b01e54e772d23c7fa723dc0d5.zip | |
treewide: Drop most cases of `sizeof(struct ...)`
Spelling out the struct type name hurts readability and introduces
opportunities for bugs to happen when the pointer variable type is
changed but the corresponding sizeof is (are) not.
TEST=`make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j`
with and without this patch; the flashrom executable does not change.
Change-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Diffstat (limited to 'pcidev.c')
| -rw-r--r-- | pcidev.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -296,7 +296,7 @@ static int undo_pci_write(void *p) #define register_undo_pci_write(a, b, c) \ { \ struct undo_pci_write_data *undo_pci_write_data; \ - undo_pci_write_data = malloc(sizeof(struct undo_pci_write_data)); \ + undo_pci_write_data = malloc(sizeof(*undo_pci_write_data)); \ if (!undo_pci_write_data) { \ msg_gerr("Out of memory!\n"); \ exit(1); \ |