diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2022-06-30 20:00:11 +1000 |
|---|---|---|
| committer | Anastasia Klimchuk <aklm@chromium.org> | 2022-08-02 02:18:00 +0000 |
| commit | dd1d07646fa6d7f1b3016937b94deeea16f8c73c (patch) | |
| tree | 7471204656533b512272b6855b8c2c5ae6502bff /parade_lspcon.c | |
| parent | f1ca19598c7e0e7ebec09fa27a556b357526907c (diff) | |
| download | flashrom-dd1d07646fa6d7f1b3016937b94deeea16f8c73c.tar.gz flashrom-dd1d07646fa6d7f1b3016937b94deeea16f8c73c.tar.bz2 flashrom-dd1d07646fa6d7f1b3016937b94deeea16f8c73c.zip | |
parade_lspcon.c: Clarify coincidentally JEDEC command usage
Clarify that SWSPI_WDATA_* coincidentally uses the same
commands as specified by JEDEC.
A similar data sheet does not really shed light if these
literally are raw JEDEC command values or 'virtual' ones.
As to avoid confusion, comment but perhaps not use the JEDEC
literals from spi.h until it is certain.
Change-Id: I851319ad4c36baad1e280309a6df8c86d6c4ad3d
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/65557
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'parade_lspcon.c')
| -rw-r--r-- | parade_lspcon.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/parade_lspcon.c b/parade_lspcon.c index f425c127..e8938c9a 100644 --- a/parade_lspcon.c +++ b/parade_lspcon.c @@ -35,10 +35,11 @@ #define ROMADDR_BYTE1 0x8e #define ROMADDR_BYTE2 0x8f #define SWSPI_WDATA 0x90 +/* SWSPI_WDATA_* appear to be numerically the same as JEDEC commands. */ #define SWSPI_WDATA_CLEAR_STATUS 0x00 - #define SWSPI_WDATA_WRITE_REGISTER 0x01 - #define SWSPI_WDATA_READ_REGISTER 0x05 - #define SWSPI_WDATA_ENABLE_REGISTER 0x06 + #define SWSPI_WDATA_WRITE_REGISTER 0x01 /* JEDEC_WRSR */ + #define SWSPI_WDATA_READ_REGISTER 0x05 /* JEDEC_RDSR */ + #define SWSPI_WDATA_ENABLE_REGISTER 0x06 /* JEDEC_WREN */ #define SWSPI_WDATA_PROTECT_BP 0x8c #define SWSPI_RDATA 0x91 #define SWSPI_LEN 0x92 |