aboutsummaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorNikolai Artemiev <nartemiev@google.com>2022-12-07 11:16:06 +1100
committerEdward O'Callaghan <quasisec@chromium.org>2022-12-15 23:55:03 +0000
commit66655b74236eb01ac0fd21ee11b5082ea720ed6b (patch)
treef411e9667c3686b35993b6492e246d1c59c83328 /include
parent77fe2663073b8006e7b3d20a1debc080831345ab (diff)
downloadflashrom-66655b74236eb01ac0fd21ee11b5082ea720ed6b.tar.gz
flashrom-66655b74236eb01ac0fd21ee11b5082ea720ed6b.tar.bz2
flashrom-66655b74236eb01ac0fd21ee11b5082ea720ed6b.zip
layout: Factor out flash_region structure from romentry
The romentry structure is the container ADT with some annotated meta-data such as 'included' or 'file' however the substantive substructure is a 'flash_region'. Therefore factor this out. That is to say, the link list node 'romentry' is obscured by the implementation details of its use-case of 'flash_region' that we clear up here. BUG=b:260440773 BRANCH=none TEST=flashrom_tester Change-Id: I768742b73db901df5b5208fcbcb8a324a06014c2 CoAuthored-by: Nikolai Artemiev <nartemiev@google.com> Signed-off-by: Nikolai Artemiev <nartemiev@google.com> Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/69196 Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Reviewed-by: Anastasia Klimchuk <aklm@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'include')
-rw-r--r--include/layout.h11
1 files changed, 8 insertions, 3 deletions
diff --git a/include/layout.h b/include/layout.h
index abbdc22c..6959ef74 100644
--- a/include/layout.h
+++ b/include/layout.h
@@ -35,14 +35,19 @@ typedef uint32_t chipsize_t; /* Able to store the number of bytes of any support
#define MAX_ROMLAYOUT 128
+struct flash_region {
+ char *name;
+ chipoff_t start;
+ chipoff_t end;
+};
+
struct romentry {
struct romentry *next;
- chipoff_t start;
- chipoff_t end;
bool included;
- char *name;
char *file;
+
+ struct flash_region region;
};
struct flashrom_layout;