diff options
| author | Peter Marheine <pmarheine@chromium.org> | 2022-01-19 17:11:09 +1100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2022-01-25 17:31:42 +0000 |
| commit | 36f87376a328ba3fe7c676c4e27214f23a5e146d (patch) | |
| tree | b1ef079b720915c40b1385d0017f0f0d0985dd8f /hwaccess_x86_io.c | |
| parent | 35547ed3afeac1d9840f11ef2bcc75624a355a11 (diff) | |
| download | flashrom-36f87376a328ba3fe7c676c4e27214f23a5e146d.tar.gz flashrom-36f87376a328ba3fe7c676c4e27214f23a5e146d.tar.bz2 flashrom-36f87376a328ba3fe7c676c4e27214f23a5e146d.zip | |
hwaccess: fix build on non-x86 targets
The changes to hwaccess in commit 49d758698a0dd166679c48b1a2785e50e9b0cc83
cause build failure on non-x86 systems because the hwaccess_x86_*
headers are included in some files that are built for all platforms
(particularly those in the internal programmer) and those headers in
turn include <sys/io.h> which only exists on x86.
This change avoids including those headers on non-x86 platforms so
the internal programmer can be built without errors.
The comment on the stub implementation of rget_io_perms() is also
modified to remove references to non-x86 platforms, since that file is
only built on x86 now.
BUG=None
TEST=meson build succeeds for both x86 and ARM targets
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Reviewed-on: https://review.coreboot.org/c/flashrom/+/61194
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'hwaccess_x86_io.c')
| -rw-r--r-- | hwaccess_x86_io.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hwaccess_x86_io.c b/hwaccess_x86_io.c index 3152bfe5..fc6ee54f 100644 --- a/hwaccess_x86_io.c +++ b/hwaccess_x86_io.c @@ -79,7 +79,6 @@ int rget_io_perms(void) #else /* DJGPP and libpayload environments have full PCI port I/O permissions by default. */ -/* PCI port I/O support is unimplemented on PPC/MIPS and unavailable on ARM. */ int rget_io_perms(void) { return 0; |