diff options
| author | Edward O'Callaghan <quasisec@google.com> | 2021-05-27 22:36:51 +1000 |
|---|---|---|
| committer | Edward O'Callaghan <quasisec@chromium.org> | 2021-05-28 07:16:53 +0000 |
| commit | 51c1f39e915e24707e5a0632d03816d1e19fae85 (patch) | |
| tree | 93c35fc97ad388b4c6517fe0d606caf299a6a444 /dummyflasher.c | |
| parent | fd8447045a690200ce3c5a4f29677d5a225a2174 (diff) | |
| download | flashrom-51c1f39e915e24707e5a0632d03816d1e19fae85.tar.gz flashrom-51c1f39e915e24707e5a0632d03816d1e19fae85.tar.bz2 flashrom-51c1f39e915e24707e5a0632d03816d1e19fae85.zip | |
dummyflasher.c: Fix use-after-free issue
Issue accidentally introduced in commit e3707bbf4.
BUG=none
BRANCH=none
TEST=builds
Change-Id: Ie12d6474ef5a7bb1afbbb9ec50b31b577da1a81b
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55014
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Diffstat (limited to 'dummyflasher.c')
| -rw-r--r-- | dummyflasher.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/dummyflasher.c b/dummyflasher.c index b7cfab8a..325263dd 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -700,12 +700,13 @@ int dummy_init(void) tmp = extract_programmer_param("spi_write_256_chunksize"); if (tmp) { data->spi_write_256_chunksize = strtoul(tmp, &endptr, 0); - free(tmp); if (*endptr != '\0' || data->spi_write_256_chunksize < 1) { msg_perr("invalid spi_write_256_chunksize\n"); + free(tmp); return 1; } } + free(tmp); tmp = extract_programmer_param("spi_blacklist"); if (tmp) { |