diff options
author | Nico Huber <nico.h@gmx.de> | 2018-12-23 20:03:35 +0100 |
---|---|---|
committer | Nico Huber <nico.h@gmx.de> | 2019-07-31 08:26:59 +0000 |
commit | 519be66fc59558971dd653afe69ccaf1a633b492 (patch) | |
tree | 74f0912de156a86d56111f377db080246e5205e9 /cbtable.c | |
parent | ef78de4a21323b8c459337356289218211f2c5ce (diff) | |
download | flashrom-519be66fc59558971dd653afe69ccaf1a633b492.tar.gz flashrom-519be66fc59558971dd653afe69ccaf1a633b492.tar.bz2 flashrom-519be66fc59558971dd653afe69ccaf1a633b492.zip |
Fix -Wsign-compare trouble
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.
Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
Diffstat (limited to 'cbtable.c')
-rw-r--r-- | cbtable.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -34,7 +34,7 @@ static char *cb_vendor = NULL, *cb_model = NULL; * -1 if IDs in the image do not match the IDs embedded in the current firmware, * 0 if the IDs could not be found in the image or if they match correctly. */ -int cb_check_image(const uint8_t *image, int size) +int cb_check_image(const uint8_t *image, unsigned int size) { const unsigned int *walk; unsigned int mb_part_offset, mb_vendor_offset; @@ -138,10 +138,10 @@ static unsigned long compute_checksum(void *addr, unsigned long length) ((((char *)rec) + rec->size) <= (((char *)head) + sizeof(*head) + head->table_bytes)); \ rec = (struct lb_record *)(((char *)rec) + rec->size)) -static int count_lb_records(struct lb_header *head) +static unsigned int count_lb_records(struct lb_header *head) { struct lb_record *rec; - int count; + unsigned int count; count = 0; for_each_lbrec(head, rec) { |