diff options
| author | Nico Huber <nico.h@gmx.de> | 2019-10-04 18:47:24 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-10-05 23:27:00 +0000 |
| commit | 92b17a52a3aaec7e87aabfc6ce5f05726d1000c0 (patch) | |
| tree | 1f2789021c48219aa78b0a2fdea8b1d7fb288353 | |
| parent | 961f4a1f29787cbb6bd9a8a43b6ac4f3f0d024c0 (diff) | |
| download | flashrom-92b17a52a3aaec7e87aabfc6ce5f05726d1000c0.tar.gz flashrom-92b17a52a3aaec7e87aabfc6ce5f05726d1000c0.tar.bz2 flashrom-92b17a52a3aaec7e87aabfc6ce5f05726d1000c0.zip | |
board_enable: Work around -Wtype-limits issue
In case of an empty `board_matches` list (i.e. on non-x86), we checked
if the `unsigned i` is smaller 0. Shuffling the computation avoids that
problem.
Change-Id: I636d73c920a7b7e7507eafe444bab8236d7acb67
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/35801
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| -rw-r--r-- | board_enable.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/board_enable.c b/board_enable.c index 98d6fd05..a5980eb3 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2493,7 +2493,7 @@ int selfcheck_board_enables(void) int ret = 0; unsigned int i; - for (i = 0; i < ARRAY_SIZE(board_matches) - 1; i++) { + for (i = 0; i + 1 < ARRAY_SIZE(board_matches); i++) { const struct board_match *b = &board_matches[i]; if (b->vendor_name == NULL || b->board_name == NULL) { msg_gerr("ERROR: Board enable #%d does not define a vendor and board name.\n" |