more work on decrypt fragment ux

1 files changed, 4 insertions, 18 deletions

diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DisplayTextFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DisplayTextFragment.java
index e252f8e75..7b3af48cc 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DisplayTextFragment.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/DisplayTextFragment.java
@@ -35,15 +35,14 @@ import org.sufficientlysecure.keychain.ui.util.Notify;
 import org.sufficientlysecure.keychain.util.ShareHelper;
 
 public class DisplayTextFragment extends DecryptFragment {
-    public static final String ARG_PLAINTEXT = "ciphertext";
-    public static final String ARG_SHOW_MENU = "show_menu";
+
+    public static final String ARG_PLAINTEXT = "plaintext";
 
     // view
     private TextView mText;
 
-    // model
-    private boolean mShowMenuOptions;
-    private String mPlaintext;
+    // model (no state to persist though, that's all in arguments!)
+    private boolean mShowMenuOptions = false;
 
     public static DisplayTextFragment newInstance(String plaintext, DecryptVerifyResult result) {
         DisplayTextFragment frag = new DisplayTextFragment();
@@ -90,10 +89,6 @@ public class DisplayTextFragment extends DecryptFragment {
         super.onCreate(savedInstanceState);
 
         setHasOptionsMenu(true);
-
-        Bundle args = getArguments();
-        mShowMenuOptions = args.getBoolean(ARG_SHOW_MENU, false);
-
     }
 
     @Override
@@ -119,15 +114,6 @@ public class DisplayTextFragment extends DecryptFragment {
     }
 
     @Override
-    public void onSaveInstanceState(Bundle outState) {
-        super.onSaveInstanceState(outState);
-
-        outState.putBoolean(ARG_SHOW_MENU, mShowMenuOptions);
-        // no need to save the decrypted text, it's in the textview
-
-    }
-
-    @Override
     protected void onVerifyLoaded(boolean hideErrorOverlay) {
         mShowMenuOptions = hideErrorOverlay;
         getActivity().supportInvalidateOptionsMenu();