diff options
| author | Vincent Breitmoser <valodim@mugenguild.com> | 2016-02-01 15:22:36 +0100 |
|---|---|---|
| committer | Vincent Breitmoser <valodim@mugenguild.com> | 2016-02-05 16:10:47 +0100 |
| commit | b1ea1261425e05d7eaa803e6ea72c1f0bbb5ae32 (patch) | |
| tree | adcf6f9d8bcfb76f0b3a22964de3e461fed49d34 /OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java | |
| parent | e3b8cea04d43d9aafec544f56aa46ccf691a575d (diff) | |
| download | open-keychain-b1ea1261425e05d7eaa803e6ea72c1f0bbb5ae32.tar.gz open-keychain-b1ea1261425e05d7eaa803e6ea72c1f0bbb5ae32.tar.bz2 open-keychain-b1ea1261425e05d7eaa803e6ea72c1f0bbb5ae32.zip | |
performance: avoid expensive getSecretKeyType call, use cached where possible
Diffstat (limited to 'OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java')
| -rw-r--r-- | OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java index 7f2a00617..95a0d41cc 100644 --- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java +++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/pgp/CanonicalizedSecretKey.java @@ -120,7 +120,9 @@ public class CanonicalizedSecretKey extends CanonicalizedPublicKey { } - public SecretKeyType getSecretKeyType() { + // This method can potentially take a LONG time (i.e. seconds), so it should only + // ever be called by ProviderHelper to be cached in the database. + public SecretKeyType getSecretKeyTypeSuperExpensive() { S2K s2k = mSecretKey.getS2K(); if (s2k != null && s2k.getType() == S2K.GNU_DUMMY_S2K) { // divert to card is special |