aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Hazali <victorhazali@gmail.com>2016-03-30 06:07:59 +0800
committerVictor Hazali <victorhazali@gmail.com>2016-03-30 06:07:59 +0800
commit5411963aff0ed017f949de5cdbcf9a83d0e2087a (patch)
treed4025550c259097ca9b87b894d1ca753d0ec77c5
parentce70568ff3f87e194ef1dd9ff04501610b7661db (diff)
downloadopen-keychain-5411963aff0ed017f949de5cdbcf9a83d0e2087a.tar.gz
open-keychain-5411963aff0ed017f949de5cdbcf9a83d0e2087a.tar.bz2
open-keychain-5411963aff0ed017f949de5cdbcf9a83d0e2087a.zip
Refactored switch statements to use constants
-rw-r--r--OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/EditSubkeyDialogFragment.java14
1 files changed, 9 insertions, 5 deletions
diff --git a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/EditSubkeyDialogFragment.java b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/EditSubkeyDialogFragment.java
index ba8920d4f..01decf2ef 100644
--- a/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/EditSubkeyDialogFragment.java
+++ b/OpenKeychain/src/main/java/org/sufficientlysecure/keychain/ui/dialog/EditSubkeyDialogFragment.java
@@ -36,6 +36,10 @@ public class EditSubkeyDialogFragment extends DialogFragment {
public static final int MESSAGE_REVOKE = 2;
public static final int MESSAGE_STRIP = 3;
public static final int MESSAGE_MOVE_KEY_TO_CARD = 4;
+ public static final int SUBKEY_MENU_CHANGE_EXPIRY = 0;
+ public static final int SUBKEY_MENU_REVOKE_SUBKEY = 1;
+ public static final int SUBKEY_MENU_STRIP_SUBKEY = 2;
+ public static final int SUBKEY_MENU_MOVE_TO_SECURITY_TOKEN = 3;
private Messenger mMessenger;
@@ -68,16 +72,16 @@ public class EditSubkeyDialogFragment extends DialogFragment {
@Override
public void onClick(DialogInterface dialog, int which) {
switch (which) {
- case 0:
+ case SUBKEY_MENU_CHANGE_EXPIRY:
sendMessageToHandler(MESSAGE_CHANGE_EXPIRY, null);
break;
- case 1:
+ case SUBKEY_MENU_REVOKE_SUBKEY:
sendMessageToHandler(MESSAGE_REVOKE, null);
break;
- case 2:
+ case SUBKEY_MENU_STRIP_SUBKEY:
showAlertDialog();
break;
- case 3:
+ case SUBKEY_MENU_MOVE_TO_SECURITY_TOKEN:
sendMessageToHandler(MESSAGE_MOVE_KEY_TO_CARD, null);
break;
default:
@@ -98,7 +102,7 @@ public class EditSubkeyDialogFragment extends DialogFragment {
private void showAlertDialog() {
CustomAlertDialogBuilder stripAlertDialog = new CustomAlertDialogBuilder(getActivity());
stripAlertDialog.setTitle(getResources().getString(R.string.title_alert_strip)).
- setMessage(R.string.alert_strip).setCancelable(true);
+ setMessage(R.string.alert_strip).setCancelable(true);
stripAlertDialog.setPositiveButton(R.string.strip, new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialogInterface, int i) {