diff options
| author | Kyle Horimoto <khorimoto@gmail.com> | 2015-10-20 18:18:47 -0700 |
|---|---|---|
| committer | Kyle Horimoto <khorimoto@gmail.com> | 2015-10-21 12:18:22 -0700 |
| commit | 4caf205c1abfd17dc4c605ec579df23df8f72d0e (patch) | |
| tree | 91a9b7ace1a011ec2755b0aff4d26875f960ff39 /app/src/main/res/values | |
| parent | d57ab6f788707defad29df2432eafe1bc4dd4e79 (diff) | |
| download | connectbot-4caf205c1abfd17dc4c605ec579df23df8f72d0e.tar.gz connectbot-4caf205c1abfd17dc4c605ec579df23df8f72d0e.tar.bz2 connectbot-4caf205c1abfd17dc4c605ec579df23df8f72d0e.zip | |
Lint and jlklein comments.
Diffstat (limited to 'app/src/main/res/values')
| -rw-r--r-- | app/src/main/res/values/dimens.xml | 23 | ||||
| -rw-r--r-- | app/src/main/res/values/styles.xml | 18 |
2 files changed, 32 insertions, 9 deletions
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml new file mode 100644 index 0000000..1889eb4 --- /dev/null +++ b/app/src/main/res/values/dimens.xml @@ -0,0 +1,23 @@ +<?xml version="1.0" encoding="utf-8"?> +<!-- + ~ ConnectBot: simple, powerful, open-source SSH client for Android + ~ Copyright 2015 Kenny Root, Jeffrey Sharkey + ~ + ~ Licensed under the Apache License, Version 2.0 (the "License"); + ~ you may not use this file except in compliance with the License. + ~ You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> + +<resources> + <dimen name="list_item_text_margin_left">72dp</dimen> + <dimen name="list_item_left_right_padding">16dp</dimen> + <dimen name="list_item_top_bottom_padding">20dp</dimen> +</resources> diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 12aea8e..93bf690 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -37,8 +37,8 @@ </style> <style name="ListItemIcon"> - <item name="android:layout_marginLeft">16dp</item> - <item name="android:layout_marginStart" tools:ignore="NewApi">16dp</item> + <item name="android:layout_marginLeft">@dimen/list_item_left_right_padding</item> + <item name="android:layout_marginStart" tools:ignore="NewApi">@dimen/list_item_left_right_padding</item> <item name="android:layout_centerVertical">true</item> <item name="android:layout_alignParentLeft">true</item> <item name="android:layout_alignParentStart" tools:ignore="NewApi">true</item> @@ -47,27 +47,27 @@ <style name="ListItemFirstLineText"> <item name="android:layout_alignParentTop">true</item> <item name="android:textColor">?android:textColorPrimary</item> - <item name="android:textSize">16sp</item> - <item name="android:paddingTop">20dp</item> + <item name="android:textSize">@dimen/list_item_left_right_padding</item> + <item name="android:paddingTop">@dimen/list_item_top_bottom_padding</item> <item name="android:layout_alignParentLeft">true</item> </style> <style name="ListItemFirstLineText.WithIcon" parent="ListItemFirstLineText"> - <item name="android:layout_marginLeft">72dp</item> - <item name="android:layout_marginStart" tools:ignore="NewApi">72dp</item> + <item name="android:layout_marginLeft">@dimen/list_item_text_margin_left</item> + <item name="android:layout_marginStart" tools:ignore="NewApi">@dimen/list_item_text_margin_left</item> </style> <style name="ListItemSecondLineText"> <item name="android:layout_alignParentBottom">true</item> <item name="android:textColor">?android:textColorSecondary</item> <item name="android:textSize">14sp</item> - <item name="android:paddingBottom">20dp</item> + <item name="android:paddingBottom">@dimen/list_item_top_bottom_padding</item> <item name="android:layout_alignParentLeft">true</item> </style> <style name="ListItemSecondLineText.WithIcon" parent="ListItemSecondLineText"> - <item name="android:layout_marginLeft">72dp</item> - <item name="android:layout_marginStart" tools:ignore="NewApi">72dp</item> + <item name="android:layout_marginLeft">@dimen/list_item_text_margin_left</item> + <item name="android:layout_marginStart" tools:ignore="NewApi">@dimen/list_item_text_margin_left</item> </style> <style name="ListItemFirstLineText.Red" parent="ListItemFirstLineText"> |