diff options
author | Kenny Root <kenny@the-b.org> | 2015-09-11 10:57:30 -0700 |
---|---|---|
committer | Kenny Root <kenny@the-b.org> | 2015-09-11 11:01:56 -0700 |
commit | 2baa56c2629532adad82d0f67abe9dd568a24760 (patch) | |
tree | a2389ad30251f44dfa9c388cf8c1cee18e5c1338 /app/src/main/java/org/connectbot/HostListActivity.java | |
parent | 5d2ebeaa409fb2f74fe9eb799793cc004f9d9d29 (diff) | |
download | connectbot-2baa56c2629532adad82d0f67abe9dd568a24760.tar.gz connectbot-2baa56c2629532adad82d0f67abe9dd568a24760.tar.bz2 connectbot-2baa56c2629532adad82d0f67abe9dd568a24760.zip |
Revert "Never cache instances of the HostDatabase"
This reverts commit 57afa9bdc5b269a48bd27fc8455cab4cb956d02a.
This won't work with injection and makes testing a bit harder, so revert
it.
Diffstat (limited to 'app/src/main/java/org/connectbot/HostListActivity.java')
-rw-r--r-- | app/src/main/java/org/connectbot/HostListActivity.java | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/app/src/main/java/org/connectbot/HostListActivity.java b/app/src/main/java/org/connectbot/HostListActivity.java index c95769c..67a0098 100644 --- a/app/src/main/java/org/connectbot/HostListActivity.java +++ b/app/src/main/java/org/connectbot/HostListActivity.java @@ -71,6 +71,7 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange protected TerminalManager bound = null; + protected HostDatabase hostdb; private List<HostBean> hosts; protected LayoutInflater inflater = null; @@ -123,6 +124,8 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange // start the terminal manager service this.bindService(new Intent(this, TerminalManager.class), connection, Context.BIND_AUTO_CREATE); + + hostdb = HostDatabase.get(this); } @Override @@ -130,6 +133,8 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange super.onStop(); this.unbindService(connection); + hostdb = null; + closeOnDisconnectAll = true; } @@ -200,6 +205,7 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange || Intent.ACTION_PICK.equals(getIntent().getAction()); // connect with hosts database and populate list + this.hostdb = HostDatabase.get(this); ListView list = this.getListView(); this.sortedByColor = prefs.getBoolean(PreferenceConstants.SORT_BY_COLOR, false); @@ -392,7 +398,7 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange if (bridge != null) bridge.dispatchDisconnect(true); - HostDatabase.get(HostListActivity.this).deleteHost(host); + hostdb.deleteHost(host); updateList(); } }) @@ -453,7 +459,6 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange return false; } - HostDatabase hostdb = HostDatabase.get(this); HostBean host = TransportFactory.findHost(hostdb, uri); if (host == null) { host = TransportFactory.getTransport(uri.getScheme()).createHost(uri); @@ -479,7 +484,9 @@ public class HostListActivity extends ListActivity implements OnHostStatusChange edit.commit(); } - HostDatabase hostdb = HostDatabase.get(this); + if (hostdb == null) + hostdb = HostDatabase.get(this); + hosts = hostdb.getHosts(sortedByColor); // Don't lose hosts that are connected via shortcuts but not in the database. |