aboutsummaryrefslogtreecommitdiffstats
path: root/web/src/js/components
diff options
context:
space:
mode:
authorClemens <cle1000.cb@gmail.com>2016-07-19 12:32:36 +0200
committerClemens <cle1000.cb@gmail.com>2016-07-19 12:32:36 +0200
commit698fb11132598a38851383f805dde5ca4d2a046d (patch)
tree95fc0184735722ccd6e4697f884496d6852e13f6 /web/src/js/components
parent48728af43ad746d70ef3e251dc28b75028dea1e6 (diff)
parent18dd84b9081fb5552d5b5b2560405496445e2110 (diff)
downloadmitmproxy-698fb11132598a38851383f805dde5ca4d2a046d.tar.gz
mitmproxy-698fb11132598a38851383f805dde5ca4d2a046d.tar.bz2
mitmproxy-698fb11132598a38851383f805dde5ca4d2a046d.zip
Merge remote-tracking branch 'origin/master' into flow_editing
Diffstat (limited to 'web/src/js/components')
-rw-r--r--web/src/js/components/ContentView.jsx147
-rw-r--r--web/src/js/components/ContentView/MetaViews.jsx2
-rw-r--r--web/src/js/components/ContentView/ViewSelector.jsx2
-rw-r--r--web/src/js/components/FlowTable/FlowTableHead.jsx6
-rw-r--r--web/src/js/components/FlowView.jsx55
-rw-r--r--web/src/js/components/Header.jsx7
-rw-r--r--web/src/js/components/Header/FilterInput.jsx5
-rw-r--r--web/src/js/components/Header/FlowMenu.jsx6
-rw-r--r--web/src/js/components/Header/MainMenu.jsx17
-rw-r--r--web/src/js/components/MainView.jsx152
-rwxr-xr-xweb/src/js/components/Prompt.jsx17
-rw-r--r--web/src/js/components/ProxyApp.jsx121
-rwxr-xr-xweb/src/js/components/ValueEditor.jsx12
-rwxr-xr-xweb/src/js/components/ValueEditor/EditorBase.jsx1
14 files changed, 132 insertions, 418 deletions
diff --git a/web/src/js/components/ContentView.jsx b/web/src/js/components/ContentView.jsx
index 3cd9990c..0b93d3f0 100644
--- a/web/src/js/components/ContentView.jsx
+++ b/web/src/js/components/ContentView.jsx
@@ -1,121 +1,68 @@
import React, { Component, PropTypes } from 'react'
import { connect } from 'react-redux'
import { MessageUtils } from '../flow/utils.js'
-import { ViewAuto, ViewImage } from './ContentView/ContentViews'
+import * as ContentViews from './ContentView/ContentViews'
import * as MetaViews from './ContentView/MetaViews'
import ContentLoader from './ContentView/ContentLoader'
import ViewSelector from './ContentView/ViewSelector'
+import { setContentView, setDisplayLarge } from '../ducks/ui'
import CodeEditor from './common/CodeEditor'
import {setModifiedFlowContent} from '../ducks/flows'
+ContentView.propTypes = {
+ // It may seem a bit weird at the first glance:
+ // Every view takes the flow and the message as props, e.g.
+ // <Auto flow={flow} message={flow.request}/>
+ flow: React.PropTypes.object.isRequired,
+ message: React.PropTypes.object.isRequired,
+}
-class ContentView extends Component {
-
- static propTypes = {
- // It may seem a bit weird at the first glance:
- // Every view takes the flow and the message as props, e.g.
- // <Auto flow={flow} message={flow.request}/>
- flow: React.PropTypes.object.isRequired,
- message: React.PropTypes.object.isRequired,
- onContentChange: React.PropTypes.func.isRequired
- }
-
- constructor(props, context) {
- super(props, context)
- this.state = { displayLarge: false, View: ViewAuto}
- this.selectView = this.selectView.bind(this)
- }
-
- selectView(View) {
- this.setState({ View })
- }
+ContentView.isContentTooLarge = msg => msg.contentLength > 1024 * 1024 * (ContentViews.ViewImage.matches(msg) ? 10 : 0.2)
- displayLarge() {
- this.setState({ displayLarge: true })
- }
+function ContentView(props) {
+ const { flow, message, contentView, selectView, displayLarge, setDisplayLarge } = props
- componentWillReceiveProps(nextProps) {
- if (nextProps.message !== this.props.message) {
- this.setState({ displayLarge: false, View: ViewAuto })
- }
+ if (message.contentLength === 0) {
+ return <MetaViews.ContentEmpty {...props}/>
}
- isContentTooLarge(msg) {
- return msg.contentLength > 1024 * 1024 * (ViewImage.matches(msg) ? 10 : 0.2)
+ if (message.contentLength === null) {
+ return <MetaViews.ContentMissing {...props}/>
}
- onOpenFile(e) {
- if (e.target.files.length > 0) {
- this.props.onContentChange(e.target.files[0])
- }
- e.preventDefault()
+ if (!displayLarge && ContentView.isContentTooLarge(message)) {
+ return <MetaViews.ContentTooLarge {...props} onClick={() => setDisplayLarge(true)}/>
}
- render() {
- const { flow, message, setModifiedFlowContent, isFlowEditorOpen } = this.props
- const { displayLarge, View } = this.state
-
- if (message.contentLength === 0) {
- return <MetaViews.ContentEmpty {...this.props}/>
- }
-
- if (message.contentLength === null) {
- return <MetaViews.ContentMissing {...this.props}/>
- }
-
- if (!displayLarge && this.isContentTooLarge(message)) {
- return <MetaViews.ContentTooLarge {...this.props} onClick={this.displayLarge}/>
- }
-
- return (
- <div>
- {isFlowEditorOpen ? (
- <ContentLoader flow={flow} message={message}>
- <CodeEditor content="" onChange={content =>{setModifiedFlowContent(content)}}/>
- </ContentLoader>
- ): (<div>
- {View.textView ? (
- <ContentLoader flow={flow} message={message}>
- <this.state.View content="" />
- </ContentLoader>
- ) : (
- <View flow={flow} message={message} />
- )}
-
-
-
- <div className="view-options text-center">
- <ViewSelector onSelectView={this.selectView} active={View} message={message}/>
- &nbsp;
- <a className="btn btn-default btn-xs"
- href={MessageUtils.getContentURL(flow, message)}
- title="Download the content of the flow."
- >
- <i className="fa fa-download"/>
- </a>
- &nbsp;
- <a className="btn btn-default btn-xs"
- href="#"
- onClick={e => {this.fileInput.click(); e.preventDefault();}}
- title="Upload a file to replace the content."
- >
- <i className="fa fa-upload"/>
- </a>
- <input
- ref={ref => this.fileInput = ref}
- className="hidden"
- type="file"
- onChange={e => this.onOpenFile(e)}
- />
- </div>
- </div>)}
+ const View = ContentViews[contentView]
+
+ return (
+ <div>
+ {View.textView ? (
+ <ContentLoader flow={flow} message={message}>
+ <View content="" />
+ </ContentLoader>
+ ) : (
+ <View flow={flow} message={message} />
+ )}
+ <div className="view-options text-center">
+ <ViewSelector onSelectView={selectView} active={View} message={message}/>
+ &nbsp;
+ <a className="btn btn-default btn-xs" href={MessageUtils.getContentURL(flow, message)}>
+ <i className="fa fa-download"/>
+ </a>
</div>
- )
- }
+ </div>
+ )
}
+
export default connect(
- state => (
- {isFlowEditorOpen : state.ui.isFlowEditorOpen}
- ), {
- setModifiedFlowContent
- })(ContentView)
+ state => ({
+ contentView: state.ui.contentView,
+ displayLarge: state.ui.displayLarge,
+ }),
+ {
+ selectView: setContentView,
+ setDisplayLarge,
+ }
+)(ContentView)
diff --git a/web/src/js/components/ContentView/MetaViews.jsx b/web/src/js/components/ContentView/MetaViews.jsx
index 83720a13..2d064b54 100644
--- a/web/src/js/components/ContentView/MetaViews.jsx
+++ b/web/src/js/components/ContentView/MetaViews.jsx
@@ -1,5 +1,5 @@
import React from 'react'
-import {formatSize} from '../../utils.js'
+import { formatSize } from '../../utils.js'
export function ContentEmpty({ flow, message }) {
return (
diff --git a/web/src/js/components/ContentView/ViewSelector.jsx b/web/src/js/components/ContentView/ViewSelector.jsx
index df3a5b83..9b151a5b 100644
--- a/web/src/js/components/ContentView/ViewSelector.jsx
+++ b/web/src/js/components/ContentView/ViewSelector.jsx
@@ -14,7 +14,7 @@ export default function ViewSelector({ active, message, onSelectView }) {
{views.map(View => (
<button
key={View.name}
- onClick={() => onSelectView(View)}
+ onClick={() => onSelectView(View.name)}
className={classnames('btn btn-default', { active: View === active })}>
{View === ViewAuto ? (
`auto: ${ViewAuto.findView(message).name.toLowerCase().replace('view', '')}`
diff --git a/web/src/js/components/FlowTable/FlowTableHead.jsx b/web/src/js/components/FlowTable/FlowTableHead.jsx
index f65369bd..50242737 100644
--- a/web/src/js/components/FlowTable/FlowTableHead.jsx
+++ b/web/src/js/components/FlowTable/FlowTableHead.jsx
@@ -3,7 +3,7 @@ import { connect } from 'react-redux'
import classnames from 'classnames'
import columns from './FlowColumns'
-import { updateSort } from '../../ducks/views/main'
+import { updateSort } from '../../ducks/flowView'
FlowTableHead.propTypes = {
updateSort: PropTypes.func.isRequired,
@@ -29,8 +29,8 @@ function FlowTableHead({ sortColumn, sortDesc, updateSort }) {
export default connect(
state => ({
- sortDesc: state.flows.views.main.sort.desc,
- sortColumn: state.flows.views.main.sort.column,
+ sortDesc: state.flowView.sort.desc,
+ sortColumn: state.flowView.sort.column,
}),
{
updateSort
diff --git a/web/src/js/components/FlowView.jsx b/web/src/js/components/FlowView.jsx
index 0ef6e5cd..5ba472a5 100644
--- a/web/src/js/components/FlowView.jsx
+++ b/web/src/js/components/FlowView.jsx
@@ -1,4 +1,5 @@
import React, { Component } from 'react'
+import { connect } from 'react-redux'
import _ from 'lodash'
import Nav from './FlowView/Nav'
@@ -6,47 +7,29 @@ import { Request, Response, ErrorView as Error } from './FlowView/Messages'
import Details from './FlowView/Details'
import Prompt from './Prompt'
+import { setPrompt, selectTab } from '../ducks/ui'
+
export default class FlowView extends Component {
static allTabs = { Request, Response, Error, Details }
constructor(props, context) {
super(props, context)
-
- this.state = { prompt: false }
-
- this.closePrompt = this.closePrompt.bind(this)
- this.selectTab = this.selectTab.bind(this)
- }
-
- getTabs() {
- return ['request', 'response', 'error'].filter(k => this.props.flow[k]).concat(['details'])
- }
-
- nextTab(increment) {
- const tabs = this.getTabs()
- // JS modulo operator doesn't correct negative numbers, make sure that we are positive.
- this.selectTab(tabs[(tabs.indexOf(this.props.tab) + increment + tabs.length) % tabs.length])
+ this.onPromptFinish = this.onPromptFinish.bind(this)
}
- selectTab(panel) {
- this.props.updateLocation(`/flows/${this.props.flow.id}/${panel}`)
- }
-
- closePrompt(edit) {
- this.setState({ prompt: false })
+ onPromptFinish(edit) {
+ this.props.setPrompt(false)
if (edit && this.tabComponent) {
this.tabComponent.edit(edit)
}
}
- promptEdit() {
- let options
-
+ getPromptOptions() {
switch (this.props.tab) {
case 'request':
- options = [
+ return [
'method',
'url',
{ text: 'http version', key: 'v' },
@@ -55,7 +38,7 @@ export default class FlowView extends Component {
break
case 'response':
- options = [
+ return [
{ text: 'http version', key: 'v' },
'code',
'message',
@@ -69,13 +52,11 @@ export default class FlowView extends Component {
default:
throw 'Unknown tab for edit: ' + this.props.tab
}
-
- this.setState({ prompt: { options, done: this.closePrompt } })
}
render() {
- const tabs = this.getTabs()
let { flow, tab: active, updateFlow } = this.props
+ const tabs = ['request', 'response', 'error'].filter(k => flow[k]).concat(['details'])
if (tabs.indexOf(active) < 0) {
if (active === 'response' && flow.error) {
@@ -95,13 +76,23 @@ export default class FlowView extends Component {
flow={flow}
tabs={tabs}
active={active}
- onSelectTab={this.selectTab}
+ onSelectTab={this.props.selectTab}
/>
<Tab ref={ tab => this.tabComponent = tab } flow={flow} updateFlow={updateFlow} />
- {this.state.prompt && (
- <Prompt {...this.state.prompt}/>
+ {this.props.promptOpen && (
+ <Prompt options={this.getPromptOptions()} done={this.onPromptFinish} />
)}
</div>
)
}
}
+
+export default connect(
+ state => ({
+ promptOpen: state.ui.promptOpen,
+ }),
+ {
+ setPrompt,
+ selectTab,
+ }
+)(FlowView)
diff --git a/web/src/js/components/Header.jsx b/web/src/js/components/Header.jsx
index b6ef1cc7..5de885ae 100644
--- a/web/src/js/components/Header.jsx
+++ b/web/src/js/components/Header.jsx
@@ -17,10 +17,10 @@ class Header extends Component {
}
render() {
- const { updateLocation, query, selectedFlow, activeMenu} = this.props
+ const { query, selectedFlowId, activeMenu} = this.props
let entries = [...Header.entries]
- if(selectedFlow)
+ if(selectedFlowId)
entries.push(FlowMenu)
const Active = _.find(entries, (e) => e.title == activeMenu)
@@ -41,7 +41,6 @@ class Header extends Component {
<div className="menu">
<Active
ref="active"
- updateLocation={updateLocation}
query={query}
/>
</div>
@@ -52,7 +51,7 @@ class Header extends Component {
export default connect(
state => ({
- selectedFlow: state.flows.views.main.selected[0],
+ selectedFlowId: state.flows.selected[0],
activeMenu: state.ui.activeMenu,
}),
{
diff --git a/web/src/js/components/Header/FilterInput.jsx b/web/src/js/components/Header/FilterInput.jsx
index 5b49b788..e421f1a4 100644
--- a/web/src/js/components/Header/FilterInput.jsx
+++ b/web/src/js/components/Header/FilterInput.jsx
@@ -7,10 +7,6 @@ import FilterDocs from './FilterDocs'
export default class FilterInput extends Component {
- static contextTypes = {
- returnFocus: React.PropTypes.func,
- }
-
constructor(props, context) {
super(props, context)
@@ -91,7 +87,6 @@ export default class FilterInput extends Component {
blur() {
ReactDOM.findDOMNode(this.refs.input).blur()
- this.context.returnFocus()
}
select() {
diff --git a/web/src/js/components/Header/FlowMenu.jsx b/web/src/js/components/Header/FlowMenu.jsx
index 8d13dd6a..bdd30d5e 100644
--- a/web/src/js/components/Header/FlowMenu.jsx
+++ b/web/src/js/components/Header/FlowMenu.jsx
@@ -15,11 +15,11 @@ function FlowMenu({ flow, acceptFlow, replayFlow, duplicateFlow, removeFlow, rev
return (
<div>
<div className="menu-row">
- <Button disabled={!flow.intercepted} title="[a]ccept intercepted flow" text="Accept" icon="fa-play" onClick={() => acceptFlow(flow)} />
+ <Button disabled={!flow || !flow.intercepted} title="[a]ccept intercepted flow" text="Accept" icon="fa-play" onClick={() => acceptFlow(flow)} />
<Button title="[r]eplay flow" text="Replay" icon="fa-repeat" onClick={() => replayFlow(flow)} />
<Button title="[D]uplicate flow" text="Duplicate" icon="fa-copy" onClick={() => duplicateFlow(flow)} />
<Button title="[d]elete flow" text="Delete" icon="fa-trash" onClick={() => removeFlow(flow)}/>
- <Button disabled={!flow.modified} title="revert changes to flow [V]" text="Revert" icon="fa-history" onClick={() => revertFlow(flow)} />
+ <Button disabled={!flow || !flow.modified} title="revert changes to flow [V]" text="Revert" icon="fa-history" onClick={() => revertFlow(flow)} />
<Button title="download" text="Download" icon="fa-download" onClick={() => window.location = MessageUtils.getContentURL(flow, flow.response)}/>
</div>
<div className="clearfix"/>
@@ -29,7 +29,7 @@ function FlowMenu({ flow, acceptFlow, replayFlow, duplicateFlow, removeFlow, rev
export default connect(
state => ({
- flow: state.flows.list.byId[state.flows.views.main.selected[0]],
+ flow: state.flows.byId[state.flows.selected[0]],
}),
{
acceptFlow: flowsActions.accept,
diff --git a/web/src/js/components/Header/MainMenu.jsx b/web/src/js/components/Header/MainMenu.jsx
index 48fea5a2..27a4be60 100644
--- a/web/src/js/components/Header/MainMenu.jsx
+++ b/web/src/js/components/Header/MainMenu.jsx
@@ -3,6 +3,7 @@ import { connect } from 'react-redux'
import FilterInput from './FilterInput'
import { Query } from '../../actions.js'
import { update as updateSettings } from '../../ducks/settings'
+import { updateQuery, setSelectedInput } from '../../ducks/ui'
class MainMenu extends Component {
@@ -12,8 +13,8 @@ class MainMenu extends Component {
static propTypes = {
query: PropTypes.object.isRequired,
settings: PropTypes.object.isRequired,
- updateLocation: PropTypes.func.isRequired,
updateSettings: PropTypes.func.isRequired,
+ updateQuery: PropTypes.func.isRequired,
}
constructor(props, context) {
@@ -22,12 +23,19 @@ class MainMenu extends Component {
this.onHighlightChange = this.onHighlightChange.bind(this)
}
+ componentWillReceiveProps(nextProps) {
+ if(this.refs[nextProps.selectedInput]) {
+ this.refs[nextProps.selectedInput].select()
+ }
+ this.props.setSelectedInput(undefined)
+ }
+
onSearchChange(val) {
- this.props.updateLocation(undefined, { [Query.SEARCH]: val })
+ this.props.updateQuery({ [Query.SEARCH]: val })
}
onHighlightChange(val) {
- this.props.updateLocation(undefined, { [Query.HIGHLIGHT]: val })
+ this.props.updateQuery({ [Query.HIGHLIGHT]: val })
}
render() {
@@ -70,9 +78,12 @@ class MainMenu extends Component {
export default connect(
state => ({
settings: state.settings.settings,
+ selectedInput: state.ui.selectedInput
}),
{
updateSettings,
+ updateQuery,
+ setSelectedInput
},
null,
{
diff --git a/web/src/js/components/MainView.jsx b/web/src/js/components/MainView.jsx
index 93f7b299..b0bbf70e 100644
--- a/web/src/js/components/MainView.jsx
+++ b/web/src/js/components/MainView.jsx
@@ -1,12 +1,11 @@
import React, { Component, PropTypes } from 'react'
import { connect } from 'react-redux'
import { Query } from '../actions.js'
-import { Key } from '../utils.js'
import Splitter from './common/Splitter'
import FlowTable from './FlowTable'
import FlowView from './FlowView'
import * as flowsActions from '../ducks/flows'
-import { select as selectFlow, updateFilter, updateHighlight } from '../ducks/views/main'
+import { updateFilter, updateHighlight } from '../ducks/flowView'
class MainView extends Component {
@@ -20,10 +19,6 @@ class MainView extends Component {
* @todo replace with mapStateToProps
*/
componentWillReceiveProps(nextProps) {
- // Update redux store with route changes
- if (nextProps.routeParams.flowId !== (nextProps.selectedFlow || {}).id) {
- this.props.selectFlow(nextProps.routeParams.flowId)
- }
if (nextProps.location.query[Query.SEARCH] !== nextProps.filter) {
this.props.updateFilter(nextProps.location.query[Query.SEARCH], false)
}
@@ -32,127 +27,6 @@ class MainView extends Component {
}
}
- /**
- * @todo move to actions
- */
- selectFlow(flow) {
- if (flow) {
- this.props.updateLocation(`/flows/${flow.id}/${this.props.routeParams.detailTab || 'request'}`)
- } else {
- this.props.updateLocation('/flows')
- }
- }
-
- /**
- * @todo move to actions
- */
- selectFlowRelative(shift) {
- const { flows, routeParams, selectedFlow } = this.props
- let index = 0
- if (!routeParams.flowId) {
- if (shift < 0) {
- index = flows.length - 1
- }
- } else {
- index = Math.min(
- Math.max(0, flows.indexOf(selectedFlow) + shift),
- flows.length - 1
- )
- }
- this.selectFlow(flows[index])
- }
-
- /**
- * @todo move to actions
- */
- onMainKeyDown(e) {
- var flow = this.props.selectedFlow
- if (e.ctrlKey) {
- return
- }
- switch (e.keyCode) {
- case Key.K:
- case Key.UP:
- this.selectFlowRelative(-1)
- break
- case Key.J:
- case Key.DOWN:
- this.selectFlowRelative(+1)
- break
- case Key.SPACE:
- case Key.PAGE_DOWN:
- this.selectFlowRelative(+10)
- break
- case Key.PAGE_UP:
- this.selectFlowRelative(-10)
- break
- case Key.END:
- this.selectFlowRelative(+1e10)
- break
- case Key.HOME:
- this.selectFlowRelative(-1e10)
- break
- case Key.ESC:
- this.selectFlow(null)
- break
- case Key.H:
- case Key.LEFT:
- if (this.refs.flowDetails) {
- this.refs.flowDetails.nextTab(-1)
- }
- break
- case Key.L:
- case Key.TAB:
- case Key.RIGHT:
- if (this.refs.flowDetails) {
- this.refs.flowDetails.nextTab(+1)
- }
- break
- case Key.C:
- if (e.shiftKey) {
- this.props.clearFlows()
- }
- break
- case Key.D:
- if (flow) {
- if (e.shiftKey) {
- this.props.duplicateFlow(flow)
- } else {
- this.props.removeFlow(flow)
- }
- }
- break
- case Key.A:
- if (e.shiftKey) {
- this.props.acceptAllFlows()
- } else if (flow && flow.intercepted) {
- this.props.acceptFlow(flow)
- }
- break
- case Key.R:
- if (!e.shiftKey && flow) {
- this.props.replayFlow(flow)
- }
- break
- case Key.V:
- if (e.shiftKey && flow && flow.modified) {
- this.props.revertFlow(flow)
- }
- break
- case Key.E:
- if (this.refs.flowDetails) {
- this.refs.flowDetails.promptEdit()
- }
- break
- case Key.SHIFT:
- break
- default:
- console.debug('keydown', e.keyCode)
- return
- }
- e.preventDefault()
- }
-
render() {
const { flows, selectedFlow, highlight } = this.props
return (
@@ -162,7 +36,7 @@ class MainView extends Component {
flows={flows}
selected={selectedFlow}
highlight={highlight}
- onSelect={flow => this.selectFlow(flow)}
+ onSelect={flow => this.props.selectFlow(flow.id)}
/>
{selectedFlow && [
<Splitter key="splitter"/>,
@@ -171,7 +45,6 @@ class MainView extends Component {
ref="flowDetails"
tab={this.props.routeParams.detailTab}
query={this.props.query}
- updateLocation={this.props.updateLocation}
updateFlow={data => this.props.updateFlow(selectedFlow, data)}
flow={selectedFlow}
/>
@@ -183,24 +56,19 @@ class MainView extends Component {
export default connect(
state => ({
- flows: state.flows.views.main.view.data,
- filter: state.flows.views.main.filter,
- highlight: state.flows.views.main.highlight,
- selectedFlow: state.flows.list.byId[state.flows.views.main.selected[0]]
+ flows: state.flowView.data,
+ filter: state.flowView.filter,
+ highlight: state.flowView.highlight,
+ selectedFlow: state.flows.byId[state.flows.selected[0]]
}),
{
- selectFlow,
+ selectFlow: flowsActions.select,
updateFilter,
updateHighlight,
updateFlow: flowsActions.update,
- clearFlows: flowsActions.clear,
- duplicateFlow: flowsActions.duplicate,
- removeFlow: flowsActions.remove,
- acceptAllFlows: flowsActions.acceptAll,
- acceptFlow: flowsActions.accept,
- replayFlow: flowsActions.replay,
- revertFlow: flowsActions.revert,
},
undefined,
- { withRef: true }
+ {
+ withRef: true
+ }
)(MainView)
diff --git a/web/src/js/components/Prompt.jsx b/web/src/js/components/Prompt.jsx
index e6564896..1c20b1a9 100755
--- a/web/src/js/components/Prompt.jsx
+++ b/web/src/js/components/Prompt.jsx
@@ -4,23 +4,15 @@ import _ from 'lodash'
import {Key} from '../utils.js'
-Prompt.contextTypes = {
- returnFocus: PropTypes.func
-}
-
Prompt.propTypes = {
options: PropTypes.array.isRequired,
done: PropTypes.func.isRequired,
prompt: PropTypes.string,
}
-export default function Prompt({ prompt, done, options }, context) {
+export default function Prompt({ prompt, done, options }) {
const opts = []
- function keyTaken(k) {
- return _.map(opts, 'key').includes(k)
- }
-
for (let i = 0; i < options.length; i++) {
let opt = options[i]
if (_.isString(opt)) {
@@ -35,7 +27,11 @@ export default function Prompt({ prompt, done, options }, context) {
}
opts.push(opt)
}
-
+
+ function keyTaken(k) {
+ return _.map(opts, 'key').includes(k)
+ }
+
function onKeyDown(event) {
event.stopPropagation()
event.preventDefault()
@@ -44,7 +40,6 @@ export default function Prompt({ prompt, done, options }, context) {
return
}
done(key.key || false)
- context.returnFocus()
}
return (
diff --git a/web/src/js/components/ProxyApp.jsx b/web/src/js/components/ProxyApp.jsx
index 1ac979bc..2962fc2b 100644
--- a/web/src/js/components/ProxyApp.jsx
+++ b/web/src/js/components/ProxyApp.jsx
@@ -4,6 +4,7 @@ import _ from 'lodash'
import { connect } from 'react-redux'
import { init as appInit, destruct as appDestruct } from '../ducks/app'
+import { onKeyDown } from '../ducks/ui'
import Header from './Header'
import EventLog from './EventLog'
import Footer from './Footer'
@@ -11,124 +12,39 @@ import { Key } from '../utils.js'
class ProxyAppMain extends Component {
- static childContextTypes = {
- returnFocus: PropTypes.func.isRequired,
- }
-
static contextTypes = {
router: PropTypes.object.isRequired,
}
- constructor(props, context) {
- super(props, context)
-
- this.focus = this.focus.bind(this)
- this.onKeyDown = this.onKeyDown.bind(this)
- this.updateLocation = this.updateLocation.bind(this)
- }
-
componentWillMount() {
- this.props.appInit()
- }
-
- /**
- * @todo listen to window's key events
- */
- componentDidMount() {
- this.focus()
+ this.props.appInit(this.context.router)
+ window.addEventListener('keydown', this.props.onKeyDown);
}
componentWillUnmount() {
- this.props.appDestruct()
- }
-
- /**
- * @todo use props
- */
- getChildContext() {
- return { returnFocus: this.focus }
- }
-
- /**
- * @todo remove it
- */
- focus() {
- document.activeElement.blur()
- window.getSelection().removeAllRanges()
- ReactDOM.findDOMNode(this).focus()
- }
-
- /**
- * @todo move to actions
- * @todo bind on window
- */
- onKeyDown(e) {
- let name = null
-
- switch (e.keyCode) {
- case Key.I:
- name = 'intercept'
- break
- case Key.L:
- name = 'search'
- break
- case Key.H:
- name = 'highlight'
- break
- default:
- let main = this.refs.view
- if (this.refs.view.refs.wrappedInstance) {
- main = this.refs.view.refs.wrappedInstance
- }
- if (main.onMainKeyDown) {
- main.onMainKeyDown(e)
- }
- return // don't prevent default then
- }
-
- if (name) {
- const headerComponent = this.refs.header.refs.wrappedInstance || this.refs.header
- headerComponent.setState({ active: Header.entries[0] }, () => {
- const active = headerComponent.refs.active.refs.wrappedInstance || headerComponent.refs.active
- active.refs[name].select()
- })
- }
-
- e.preventDefault()
+ this.props.appDestruct(this.context.router)
+ window.removeEventListener('keydown', this.props.onKeyDown);
}
- /**
- * @todo move to actions
- */
- updateLocation(pathname, queryUpdate) {
- if (pathname === undefined) {
- pathname = this.props.location.pathname
+ componentWillReceiveProps(nextProps) {
+ if (nextProps.query === this.props.query && nextProps.selectedFlowId === this.props.selectedFlowId && nextProps.panel === this.props.panel) {
+ return
}
- const query = this.props.location.query
- for (const key of Object.keys(queryUpdate || {})) {
- query[key] = queryUpdate[key] || undefined
+ if (nextProps.selectedFlowId) {
+ this.context.router.replace({ pathname: `/flows/${nextProps.selectedFlowId}/${nextProps.panel}`, query: nextProps.query })
+ } else {
+ this.context.router.replace({ pathname: '/flows', query: nextProps.query })
}
- this.context.router.replace({ pathname, query })
- }
-
- /**
- * @todo pass in with props
- */
- getQuery() {
- // For whatever reason, react-router always returns the same object, which makes comparing
- // the current props with nextProps impossible. As a workaround, we just clone the query object.
- return _.clone(this.props.location.query)
}
render() {
- const { showEventLog, location, children } = this.props
- const query = this.getQuery()
+ const { showEventLog, location, children, query } = this.props
return (
- <div id="container" tabIndex="0" onKeyDown={this.onKeyDown}>
- <Header ref="header" updateLocation={this.updateLocation} query={query} />
+ <div id="container" tabIndex="0">
+ <Header ref="header" query={query} />
{React.cloneElement(
children,
- { ref: 'view', location, query, updateLocation: this.updateLocation }
+ { ref: 'view', location, query }
)}
{showEventLog && (
<EventLog key="eventlog"/>
@@ -142,10 +58,13 @@ class ProxyAppMain extends Component {
export default connect(
state => ({
showEventLog: state.eventLog.visible,
- settings: state.settings.settings,
+ query: state.ui.query,
+ panel: state.ui.panel,
+ selectedFlowId: state.flows.selected[0]
}),
{
appInit,
appDestruct,
+ onKeyDown
}
)(ProxyAppMain)
diff --git a/web/src/js/components/ValueEditor.jsx b/web/src/js/components/ValueEditor.jsx
index 0316924f..5f1bf2dc 100755
--- a/web/src/js/components/ValueEditor.jsx
+++ b/web/src/js/components/ValueEditor.jsx
@@ -4,27 +4,17 @@ import ValidateEditor from './ValueEditor/ValidateEditor'
export default class ValueEditor extends Component {
- static contextTypes = {
- returnFocus: PropTypes.func,
- }
-
static propTypes = {
content: PropTypes.string.isRequired,
onDone: PropTypes.func.isRequired,
inline: PropTypes.bool,
}
- constructor(props) {
- super(props)
- this.focus = this.focus.bind(this)
- }
-
render() {
- var tag = this.props.inline ? "span" : 'div'
+ var tag = this.props.inline ? 'span' : 'div'
return (
<ValidateEditor
{...this.props}
- onStop={() => this.context.returnFocus()}
tag={tag}
/>
)
diff --git a/web/src/js/components/ValueEditor/EditorBase.jsx b/web/src/js/components/ValueEditor/EditorBase.jsx
index e737d2af..aa09dad5 100755
--- a/web/src/js/components/ValueEditor/EditorBase.jsx
+++ b/web/src/js/components/ValueEditor/EditorBase.jsx
@@ -54,7 +54,6 @@ export default class EditorBase extends Component {
render() {
return (
<this.props.tag
- {...this.props}
tabIndex="0"
className={`inline-input ${this.props.className}`}
contentEditable={this.state.editable || undefined}