aboutsummaryrefslogtreecommitdiffstats
path: root/web/src/js/components/Modal/Option.jsx
diff options
context:
space:
mode:
authorMatthew Shao <me@matshao.com>2017-07-18 14:46:18 +0800
committerMatthew Shao <me@matshao.com>2017-07-18 14:46:18 +0800
commitc2f0b94fb7717aa46f7da27d56bf497efaa747b1 (patch)
tree625afab6aeeca19a00f62b7edeb7e78c325c144e /web/src/js/components/Modal/Option.jsx
parent70bb123101fa59f3f60bdca254cdbdd3e89de568 (diff)
downloadmitmproxy-c2f0b94fb7717aa46f7da27d56bf497efaa747b1.tar.gz
mitmproxy-c2f0b94fb7717aa46f7da27d56bf497efaa747b1.tar.bz2
mitmproxy-c2f0b94fb7717aa46f7da27d56bf497efaa747b1.zip
[web] sorting the options and minor improve ux.
Diffstat (limited to 'web/src/js/components/Modal/Option.jsx')
-rw-r--r--web/src/js/components/Modal/Option.jsx21
1 files changed, 12 insertions, 9 deletions
diff --git a/web/src/js/components/Modal/Option.jsx b/web/src/js/components/Modal/Option.jsx
index e2f6708f..1c7bc2b2 100644
--- a/web/src/js/components/Modal/Option.jsx
+++ b/web/src/js/components/Modal/Option.jsx
@@ -3,6 +3,7 @@ import PropTypes from "prop-types"
import { connect } from "react-redux"
import { update as updateOptions } from "../../ducks/options"
import { Key } from "../../utils"
+import classnames from 'classnames'
const stopPropagation = e => {
if (e.keyCode !== Key.ESC) {
@@ -93,7 +94,7 @@ function StringSequenceOption({ value, onChange, ...props }) {
const height = Math.max(value.length, 1)
return <textarea
rows={height}
- value={value.join("\n")}
+ value={value.join('\n')}
onChange={e => onChange(e.target.value.split("\n").filter(x => x.trim()))}
{...props}
/>
@@ -107,7 +108,7 @@ const Options = {
"sequence of str": StringSequenceOption,
}
-function PureOption({ choices, type, value, onChange, name }) {
+function PureOption({ choices, type, value, onChange, name, error }) {
let Opt, props = {}
if (choices) {
Opt = ChoicesOption;
@@ -119,13 +120,15 @@ function PureOption({ choices, type, value, onChange, name }) {
props.className = "form-control"
}
- return <Opt
- name={name}
- value={value}
- onChange={onChange}
- onKeyDown={stopPropagation}
- {...props}
- />
+ return <div className={classnames({'has-error':error})}>
+ <Opt
+ name={name}
+ value={value}
+ onChange={onChange}
+ onKeyDown={stopPropagation}
+ {...props}
+ />
+ </div>
}
export default connect(
(state, { name }) => ({