aboutsummaryrefslogtreecommitdiffstats
path: root/test
diff options
context:
space:
mode:
authorMarcus R. Matos <marcus@matosconsulting.com>2020-04-05 15:50:28 -0500
committerMarcus R. Matos <marcus@matosconsulting.com>2020-04-05 15:50:28 -0500
commit901c0f6ede67b419e263eb1876f8720c791ed07f (patch)
tree15c9f868f73cf09039acc2e3b273cd895aa22376 /test
parent2722f4fd764657b1f059c66aa75a879acd56abca (diff)
downloadmitmproxy-901c0f6ede67b419e263eb1876f8720c791ed07f.tar.gz
mitmproxy-901c0f6ede67b419e263eb1876f8720c791ed07f.tar.bz2
mitmproxy-901c0f6ede67b419e263eb1876f8720c791ed07f.zip
#3885 implement simpler regex for host validation
Diffstat (limited to 'test')
-rw-r--r--test/mitmproxy/net/test_check.py10
1 files changed, 2 insertions, 8 deletions
diff --git a/test/mitmproxy/net/test_check.py b/test/mitmproxy/net/test_check.py
index 7def75fd..649e71da 100644
--- a/test/mitmproxy/net/test_check.py
+++ b/test/mitmproxy/net/test_check.py
@@ -13,7 +13,8 @@ def test_is_valid_host():
assert check.is_valid_host(b"one_two")
assert check.is_valid_host(b"::1")
- # IPv6 Validations
+ # IP Address Validations
+ assert check.is_valid_host(b'127.0.0.1')
assert check.is_valid_host(b'2001:0db8:85a3:0000:0000:8a2e:0370:7334')
assert check.is_valid_host(b'2001:db8:85a3:0:0:8a2e:370:7334')
assert check.is_valid_host(b'2001:db8:85a3::8a2e:370:7334')
@@ -21,7 +22,6 @@ def test_is_valid_host():
assert check.is_valid_host(b'2001-db8-85a3-8d3-1319-8a2e-370-7348.ipv6-literal.net')
# TLD must be between 2 and 63 chars
- assert not check.is_valid_host(b'example.t')
assert check.is_valid_host(b'example.tl')
assert check.is_valid_host(b'example.tld')
assert check.is_valid_host(b'example.' + b"x" * 63)
@@ -51,9 +51,6 @@ def test_is_valid_host():
assert check.is_valid_host(b'_a.example.tld')
assert check.is_valid_host(b'a_.example.tld')
assert check.is_valid_host(b'_a_.example.tld')
- assert not check.is_valid_host(b'a._example')
- assert not check.is_valid_host(b'a._example_')
- assert not check.is_valid_host(b'a.example_')
# Misc Dash/Hyphen/Minus Test Cases
assert check.is_valid_host(b'-example')
@@ -62,9 +59,6 @@ def test_is_valid_host():
assert check.is_valid_host(b'-a.example.tld')
assert check.is_valid_host(b'a-.example.tld')
assert check.is_valid_host(b'-a-.example.tld')
- assert not check.is_valid_host(b'a.-example')
- assert not check.is_valid_host(b'a.-example-')
- assert not check.is_valid_host(b'a.example-')
# Misc Combo Test Cases
assert check.is_valid_host(b'api-.example.com')