Options - avoid mutation, API cleanup, has_changed

- Always return a deepcopy of options to avoid accidental mutation of options
state.
- Remove .get(opt, default). This is an inappropriate API for Options - trying
to retrieve an option that doesn't exist should always be an error.
- Add the has_changed method that checks if an option differs from the default,
use it in mitmproxy console.

1 files changed, 5 insertions, 2 deletions

diff --git a/test/mitmproxy/test_optmanager.py b/test/mitmproxy/test_optmanager.py
index 47e40d98..345512fd 100644
--- a/test/mitmproxy/test_optmanager.py
+++ b/test/mitmproxy/test_optmanager.py
@@ -35,6 +35,7 @@ def test_defaults():
         "three": "dthree",
         "four": "dfour",
     }
+    assert not o.has_changed("one")
     newvals = dict(
         one="xone",
         two="xtwo",
@@ -42,11 +43,13 @@ def test_defaults():
         four="xfour",
     )
     o.update(**newvals)
+    assert o.has_changed("one")
     for k, v in newvals.items():
-        assert v == o.get(k)
+        assert v == getattr(o, k)
     o.reset()
+    assert not o.has_changed("one")
     for k, v in o._defaults.items():
-        assert v == o.get(k)
+        assert v == getattr(o, k)
 
 
 def test_options():