diff options
author | Henrique <typoon@gmail.com> | 2019-11-16 17:01:47 -0500 |
---|---|---|
committer | Henrique <typoon@gmail.com> | 2019-11-16 17:01:47 -0500 |
commit | 7779eef572e8deeae895ea6d700265e6f9b432c8 (patch) | |
tree | 76763b3f6c98629d94376a12887608aef6a8f151 /mitmproxy/types.py | |
parent | 373cc945c0fb15d0713166019ae0132f07c469e2 (diff) | |
download | mitmproxy-7779eef572e8deeae895ea6d700265e6f9b432c8.tar.gz mitmproxy-7779eef572e8deeae895ea6d700265e6f9b432c8.tar.bz2 mitmproxy-7779eef572e8deeae895ea6d700265e6f9b432c8.zip |
Various changes to address PR comments
Made a change to make `CommandManager.execute` the main entry point for
executing commands and made `call_strings` into a private method.
Diffstat (limited to 'mitmproxy/types.py')
-rw-r--r-- | mitmproxy/types.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mitmproxy/types.py b/mitmproxy/types.py index 0634e4d7..b48aef84 100644 --- a/mitmproxy/types.py +++ b/mitmproxy/types.py @@ -47,7 +47,7 @@ class Choice: class _CommandBase: commands: typing.MutableMapping[str, typing.Any] = {} - def call_strings(self, path: str, args: typing.Sequence[str]) -> typing.Any: + def _call_strings(self, path: str, args: typing.Sequence[str]) -> typing.Any: raise NotImplementedError def execute(self, cmd: str) -> typing.Any: @@ -337,7 +337,7 @@ class _FlowType(_BaseFlowType): def parse(self, manager: _CommandBase, t: type, s: str) -> flow.Flow: try: - flows = manager.call_strings("view.flows.resolve", [s]) + flows = manager.execute("view.flows.resolve %s" % (s)) except exceptions.CommandError as e: raise exceptions.TypeError from e if len(flows) != 1: @@ -356,7 +356,7 @@ class _FlowsType(_BaseFlowType): def parse(self, manager: _CommandBase, t: type, s: str) -> typing.Sequence[flow.Flow]: try: - return manager.call_strings("view.flows.resolve", [s]) + return manager.execute("view.flows.resolve %s" % (s)) except exceptions.CommandError as e: raise exceptions.TypeError from e |