aboutsummaryrefslogtreecommitdiffstats
path: root/libmproxy/protocol
diff options
context:
space:
mode:
authorMaximilian Hils <git@maximilianhils.com>2014-03-11 02:16:22 +0100
committerMaximilian Hils <git@maximilianhils.com>2014-03-11 02:16:22 +0100
commit15c82f743f6969b11afe17ecb82840e70d6b3ba3 (patch)
tree6eb6041f2db1be8a4f07d97e777bd877d6194049 /libmproxy/protocol
parentc1fff51b1bf25ac048149398ae6b6dc14882a838 (diff)
downloadmitmproxy-15c82f743f6969b11afe17ecb82840e70d6b3ba3.tar.gz
mitmproxy-15c82f743f6969b11afe17ecb82840e70d6b3ba3.tar.bz2
mitmproxy-15c82f743f6969b11afe17ecb82840e70d6b3ba3.zip
fix temporary server change, coverage++
Diffstat (limited to 'libmproxy/protocol')
-rw-r--r--libmproxy/protocol/primitives.py17
1 files changed, 7 insertions, 10 deletions
diff --git a/libmproxy/protocol/primitives.py b/libmproxy/protocol/primitives.py
index 81730616..dfe6371e 100644
--- a/libmproxy/protocol/primitives.py
+++ b/libmproxy/protocol/primitives.py
@@ -1,8 +1,9 @@
from __future__ import absolute_import
+import copy
+import netlib.tcp
from .. import stateobject, utils, version
from ..proxy.primitives import AddressPriority
from ..proxy.connection import ClientConnection, ServerConnection
-import copy
KILL = 0 # const for killed requests
@@ -161,16 +162,12 @@ class TemporaryServerChangeMixin(object):
without any need to expose the ConnectionHandler to the Flow.
"""
def change_server(self, address, ssl):
+ address = netlib.tcp.Address.wrap(address)
if address == self.c.server_conn.address():
return
priority = AddressPriority.MANUALLY_CHANGED
- if self.c.server_conn.priority > priority:
- self.log("Attempt to change server address, "
- "but priority is too low (is: %s, got: %s)" % (self.server_conn.priority, priority))
- return
-
- self.log("Temporarily change server connection: %s:%s -> %s:%s" % (
+ self.c.log("Temporarily change server connection: %s:%s -> %s:%s" % (
self.c.server_conn.address.host,
self.c.server_conn.address.port,
address.host,
@@ -191,11 +188,11 @@ class TemporaryServerChangeMixin(object):
if not hasattr(self, "_backup_server_conn"):
return
- self.log("Restore original server connection: %s:%s -> %s:%s" % (
+ self.c.log("Restore original server connection: %s:%s -> %s:%s" % (
self.c.server_conn.address.host,
self.c.server_conn.address.port,
- self._backup_server_conn.host,
- self._backup_server_conn.port
+ self._backup_server_conn.address.host,
+ self._backup_server_conn.address.port
))
self.c.del_server_connection()