diff options
| author | Maximilian Hils <git@maximilianhils.com> | 2016-02-02 12:32:58 +0100 |
|---|---|---|
| committer | Thomas Kriechbaumer <thomas@kriechbaumer.name> | 2016-02-04 09:52:28 +0100 |
| commit | 6bc1755750f8a7986ab26ff28ea0e90ad0ccaacd (patch) | |
| tree | 40f79cce3e71df9e20b42ab1c03071258df365b0 /libmproxy/models | |
| parent | 74e62903c13d9f1f1545a31ff019cdfc5e83ddda (diff) | |
| download | mitmproxy-6bc1755750f8a7986ab26ff28ea0e90ad0ccaacd.tar.gz mitmproxy-6bc1755750f8a7986ab26ff28ea0e90ad0ccaacd.tar.bz2 mitmproxy-6bc1755750f8a7986ab26ff28ea0e90ad0ccaacd.zip | |
add comment that explains OrderedDict use
Diffstat (limited to 'libmproxy/models')
| -rw-r--r-- | libmproxy/models/http.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/libmproxy/models/http.py b/libmproxy/models/http.py index a52597b4..8a0b226d 100644 --- a/libmproxy/models/http.py +++ b/libmproxy/models/http.py @@ -14,6 +14,10 @@ from .flow import Flow from collections import OrderedDict class MessageMixin(stateobject.StateObject): + # The restoration order is important currently, e.g. because + # of .content setting .headers["content-length"] automatically. + # Using OrderedDict is the short term fix, restoring state should + # be implemented without side-effects again. _stateobject_attributes = OrderedDict( http_version=bytes, headers=Headers, |