diff options
author | Aldo Cortesi <aldo@nullcube.com> | 2017-04-25 19:06:24 +1200 |
---|---|---|
committer | Aldo Cortesi <aldo@nullcube.com> | 2017-04-25 22:13:44 +1200 |
commit | e6eeab60946e61047ed858422badbda189a6f9e8 (patch) | |
tree | c0bc4775cd24824a3c2ff7df73c3b6078874eb70 /examples/simple/io_write_dumpfile.py | |
parent | 90c425bd14087a984afd92eec2c18e63707e4ffa (diff) | |
download | mitmproxy-e6eeab60946e61047ed858422badbda189a6f9e8.tar.gz mitmproxy-e6eeab60946e61047ed858422badbda189a6f9e8.tar.bz2 mitmproxy-e6eeab60946e61047ed858422badbda189a6f9e8.zip |
Revamp how addons work
- Addons now nest, which means that addons can manage addons. This has a number
of salutary effects - the scripts addon no longer has to poke into the global
addons list, we no longer have to replace/remove/boot-outof parent addons when
we load scripts, and this paves the way for making our top-level tools into
addons themselves.
- All addon calls are now wrapped in a safe execution environment where
exceptions are caught, and output to stdout/stderr are intercepted and turned
into logs.
- We no longer support script arguments in sys.argv - creating an option
properly is the only way to pass arguments. This means that all scripts are
always directly controllable from interctive tooling, and that arguments are
type-checked.
For now, I've disabled testing of the har dump example - it needs to be moved
to the new argument handling, and become a class addon. I'll address that in a
separate patch.
Diffstat (limited to 'examples/simple/io_write_dumpfile.py')
-rw-r--r-- | examples/simple/io_write_dumpfile.py | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/examples/simple/io_write_dumpfile.py b/examples/simple/io_write_dumpfile.py index 15e7693c..a0956e33 100644 --- a/examples/simple/io_write_dumpfile.py +++ b/examples/simple/io_write_dumpfile.py @@ -23,7 +23,4 @@ class Writer: self.w.add(flow) -def load(l): - if len(sys.argv) != 2: - raise ValueError('Usage: -s "flowriter.py filename"') - l.boot_into(Writer(sys.argv[1])) +addons = [Writer(sys.argv[1])] |