diff options
| author | Aldo Cortesi <aldo@nullcube.com> | 2011-09-05 07:47:47 +1200 |
|---|---|---|
| committer | Aldo Cortesi <aldo@nullcube.com> | 2011-09-05 07:47:47 +1200 |
| commit | e5bded7deecb396bef33ebc0a5e345e4d8cf7928 (patch) | |
| tree | 9c737f16764d9aca3f8efe58b7ca4a4cdec01a1e | |
| parent | 4cb0e5bfb47264c727b2f7ac0615e5d34e85609b (diff) | |
| download | mitmproxy-e5bded7deecb396bef33ebc0a5e345e4d8cf7928.tar.gz mitmproxy-e5bded7deecb396bef33ebc0a5e345e4d8cf7928.tar.bz2 mitmproxy-e5bded7deecb396bef33ebc0a5e345e4d8cf7928.zip | |
Improve robustness against invalid data.
| -rw-r--r-- | libmproxy/proxy.py | 6 | ||||
| -rw-r--r-- | libmproxy/utils.py | 7 | ||||
| -rw-r--r-- | test/test_utils.py | 3 |
3 files changed, 12 insertions, 4 deletions
diff --git a/libmproxy/proxy.py b/libmproxy/proxy.py index 5a2a4f43..f0640f23 100644 --- a/libmproxy/proxy.py +++ b/libmproxy/proxy.py @@ -104,7 +104,6 @@ def parse_request_line(request): return method, scheme, host, port, path, minor - class FileLike: def __init__(self, o): self.o = o @@ -197,7 +196,10 @@ class ServerConnection: if not len(parts) == 3: raise ProxyError(502, "Invalid server response: %s."%line) proto, code, msg = parts - code = int(code) + try: + code = int(code) + except ValueError: + raise ProxyError(502, "Invalid server response: %s."%line) headers = flow.Headers() headers.read(self.rfile) if code >= 100 and code <= 199: diff --git a/libmproxy/utils.py b/libmproxy/utils.py index ecf77263..37b751dc 100644 --- a/libmproxy/utils.py +++ b/libmproxy/utils.py @@ -393,8 +393,11 @@ def parse_url(url): if not scheme: return None if ':' in netloc: - host, port = string.split(netloc, ':') - port = int(port) + host, port = string.rsplit(netloc, ':', maxsplit=1) + try: + port = int(port) + except ValueError: + return None else: host = netloc if scheme == "https": diff --git a/test/test_utils.py b/test/test_utils.py index 8b16e057..12917444 100644 --- a/test/test_utils.py +++ b/test/test_utils.py @@ -216,6 +216,9 @@ class u_parse_url(libpry.AutoTree): s, h, po, pa = utils.parse_url("https://foo") assert po == 443 + assert not utils.parse_url("https://foo:bar") + assert not utils.parse_url("https://foo:") + tests = [ uformat_timestamp(), uisBin(), |