aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaximilian Hils <git@maximilianhils.com>2014-09-06 12:39:23 +0200
committerMaximilian Hils <git@maximilianhils.com>2014-09-06 12:39:23 +0200
commitccb61829175b6ecb15cc753c5d134fe7b445b2ef (patch)
tree5e3ec4debfb5021357ce1e174317f1ab19bf1cd2
parent32e1ed212da8095530abad4ac41f10ee8a599c74 (diff)
downloadmitmproxy-ccb61829175b6ecb15cc753c5d134fe7b445b2ef.tar.gz
mitmproxy-ccb61829175b6ecb15cc753c5d134fe7b445b2ef.tar.bz2
mitmproxy-ccb61829175b6ecb15cc753c5d134fe7b445b2ef.zip
fix race condition with the concurrent decorator
-rw-r--r--libmproxy/script.py25
1 files changed, 19 insertions, 6 deletions
diff --git a/libmproxy/script.py b/libmproxy/script.py
index 706d84d5..f5fb6b41 100644
--- a/libmproxy/script.py
+++ b/libmproxy/script.py
@@ -108,15 +108,28 @@ class Script:
return (False, None)
+class ReplyProxy(object):
+ def __init__(self, original_reply):
+ self._ignore_calls = 1
+ self.lock = threading.Lock()
+ self.original_reply = original_reply
+
+ def __call__(self, *args, **kwargs):
+ with self.lock:
+ if self._ignore_calls > 0:
+ self._ignore_calls -= 1
+ return
+ self.original_reply(*args, **kwargs)
+
+ def __getattr__ (self, k):
+ return getattr(self.original_reply, k)
+
+
def _handle_concurrent_reply(fn, o, *args, **kwargs):
# Make first call to o.reply a no op
- original_reply = o.reply
- def restore_original_reply():
- o.reply = original_reply
- if hasattr(original_reply, "q"):
- restore_original_reply.q = original_reply.q
- o.reply = restore_original_reply
+ reply_proxy = ReplyProxy(o.reply)
+ o.reply = reply_proxy
def run():
fn(*args, **kwargs)