aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAldo Cortesi <aldo@nullcube.com>2012-02-18 16:29:02 +1300
committerAldo Cortesi <aldo@nullcube.com>2012-02-18 16:29:02 +1300
commit7aa79b89e89385a234741589bef730cc0085662a (patch)
treef9b10544a61feb003356ea6fbaac4ccdff32af8c
parent6ad8b1a15d725f34990cfe3ae650fa239171a044 (diff)
downloadmitmproxy-7aa79b89e89385a234741589bef730cc0085662a.tar.gz
mitmproxy-7aa79b89e89385a234741589bef730cc0085662a.tar.bz2
mitmproxy-7aa79b89e89385a234741589bef730cc0085662a.zip
Firm up what we consider to be a valid proxy spec.
-rw-r--r--libmproxy/utils.py2
-rw-r--r--test/test_utils.py1
2 files changed, 2 insertions, 1 deletions
diff --git a/libmproxy/utils.py b/libmproxy/utils.py
index f3c36f8f..16540434 100644
--- a/libmproxy/utils.py
+++ b/libmproxy/utils.py
@@ -422,7 +422,7 @@ def parse_url(url):
def parse_proxy_spec(url):
p = parse_url(url)
- if not p:
+ if not p or not p[1]:
return None
return p[:3]
diff --git a/test/test_utils.py b/test/test_utils.py
index 90585194..510dbd59 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -206,6 +206,7 @@ class u_parse_proxy_spec(libpry.AutoTree):
assert utils.parse_proxy_spec("http://foo.com:88") == ("http", "foo.com", 88)
assert utils.parse_proxy_spec("http://foo.com") == ("http", "foo.com", 80)
assert not utils.parse_proxy_spec("foo.com")
+ assert not utils.parse_proxy_spec("http://")
class u_unparse_url(libpry.AutoTree):