aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikhil Soni <krsoninikhil@gmail.com>2017-02-22 23:32:16 +0530
committerNikhil Soni <krsoninikhil@gmail.com>2017-03-03 12:34:20 +0530
commit2e90373e4b484b94d0306b9764c7416b6156304f (patch)
treeda95a53ac12354f8e11ca51475eeb1719d4ffc9c
parent14d8c91250aeb0e1e8d76b83bfa15c00c8091700 (diff)
downloadmitmproxy-2e90373e4b484b94d0306b9764c7416b6156304f.tar.gz
mitmproxy-2e90373e4b484b94d0306b9764c7416b6156304f.tar.bz2
mitmproxy-2e90373e4b484b94d0306b9764c7416b6156304f.zip
Updates help msg and docs for --keep-host-header
-rw-r--r--docs/features/reverseproxy.rst5
-rw-r--r--mitmproxy/tools/cmdline.py2
2 files changed, 4 insertions, 3 deletions
diff --git a/docs/features/reverseproxy.rst b/docs/features/reverseproxy.rst
index 85ad33e8..f58fad95 100644
--- a/docs/features/reverseproxy.rst
+++ b/docs/features/reverseproxy.rst
@@ -31,7 +31,8 @@ Host Header
In reverse proxy mode, mitmproxy automatically rewrites the Host header to match the
upstream server. This allows mitmproxy to easily connect to existing endpoints on the
-open web (e.g. ``mitmproxy -R https://example.com``).
+open web (e.g. ``mitmproxy -R https://example.com``). But this behaviour can be
+be disabled by passing ``--keep-host-header`` on the console.
However, keep in mind that absolute URLs within the returned document or HTTP redirects will
NOT be rewritten by mitmproxy. This means that if you click on a link for "http://example.com"
@@ -39,4 +40,4 @@ in the returned web page, you will be taken directly to that URL, bypassing mitm
One possible way to address this is to modify the hosts file of your OS so that "example.com"
resolves to your proxy's IP, and then access the proxy by going directly to example.com.
-Make sure that your proxy can still resolve the original IP, or specify an IP in mitmproxy. \ No newline at end of file
+Make sure that your proxy can still resolve the original IP, or specify an IP in mitmproxy.
diff --git a/mitmproxy/tools/cmdline.py b/mitmproxy/tools/cmdline.py
index 18db3c8f..11558cc3 100644
--- a/mitmproxy/tools/cmdline.py
+++ b/mitmproxy/tools/cmdline.py
@@ -391,7 +391,7 @@ def proxy_options(parser):
group.add_argument(
"--keep-host-header",
action="store_true", dest="keep_host_header",
- help="Keep the host header as proxy addres"
+ help="Reverse Proxy: Keep the original host header instead of rewriting it to the reverse proxy target."
)