aboutsummaryrefslogtreecommitdiffstats
path: root/src/cryptography/hazmat/backends/openssl/x509.py
diff options
context:
space:
mode:
authorAlex Gaynor <alex.gaynor@gmail.com>2018-08-31 09:04:25 -0400
committerPaul Kehrer <paul.l.kehrer@gmail.com>2018-08-31 09:04:25 -0400
commit9a53a4b9aadb4522d9354d722c3dbdfcb5bbf0bc (patch)
tree58029a6ecb593c47f32d9e44c4436888918561ea /src/cryptography/hazmat/backends/openssl/x509.py
parent6511f88140da1e948cdaa63a4f8d0fef21003b34 (diff)
downloadcryptography-9a53a4b9aadb4522d9354d722c3dbdfcb5bbf0bc.tar.gz
cryptography-9a53a4b9aadb4522d9354d722c3dbdfcb5bbf0bc.tar.bz2
cryptography-9a53a4b9aadb4522d9354d722c3dbdfcb5bbf0bc.zip
Fixed two memory leaks in x509 csr extensions (#4434)
* Fixed a memory leak in x.509 OCSP no check * Fix the _actual_ leak * Speed up symbolizations * Disable backtrace by default, because it doesn't work on Windows * line length
Diffstat (limited to 'src/cryptography/hazmat/backends/openssl/x509.py')
-rw-r--r--src/cryptography/hazmat/backends/openssl/x509.py8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/cryptography/hazmat/backends/openssl/x509.py b/src/cryptography/hazmat/backends/openssl/x509.py
index b870eeb7..a7a2c70d 100644
--- a/src/cryptography/hazmat/backends/openssl/x509.py
+++ b/src/cryptography/hazmat/backends/openssl/x509.py
@@ -429,6 +429,14 @@ class _CertificateSigningRequest(object):
@utils.cached_property
def extensions(self):
x509_exts = self._backend._lib.X509_REQ_get_extensions(self._x509_req)
+ x509_exts = self._backend._ffi.gc(
+ x509_exts,
+ lambda x: self._backend._lib.sk_X509_EXTENSION_pop_free(
+ x, self._backend._ffi.addressof(
+ self._backend._lib._original_lib, "X509_EXTENSION_free"
+ )
+ )
+ )
return _CSR_EXTENSION_PARSER.parse(self._backend, x509_exts)
def public_bytes(self, encoding):