diff options
| author | Alex Gaynor <alex.gaynor@gmail.com> | 2019-05-09 19:11:21 -0400 |
|---|---|---|
| committer | Paul Kehrer <paul.l.kehrer@gmail.com> | 2019-05-09 19:11:21 -0400 |
| commit | ea4d1ee3fa6c052aa0ef4af9b2be6d6aabdd852b (patch) | |
| tree | c0dc25c81ccbcec47e74656939684f491426a1cf /docs | |
| parent | fccbfc0fb97485f27f271fdccc60a7e8a01dc771 (diff) | |
| download | cryptography-ea4d1ee3fa6c052aa0ef4af9b2be6d6aabdd852b.tar.gz cryptography-ea4d1ee3fa6c052aa0ef4af9b2be6d6aabdd852b.tar.bz2 cryptography-ea4d1ee3fa6c052aa0ef4af9b2be6d6aabdd852b.zip | |
Order the elements in reviewing patches reasonably (#4883)
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/development/reviewing-patches.rst | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/docs/development/reviewing-patches.rst b/docs/development/reviewing-patches.rst index bd3ee96a..08446183 100644 --- a/docs/development/reviewing-patches.rst +++ b/docs/development/reviewing-patches.rst @@ -7,18 +7,18 @@ review is our opportunity to share knowledge, design ideas and make friends. When reviewing a patch try to keep each of these concepts in mind: -Architecture ------------- - -* Is the proposed change being made in the correct place? Is it a fix in a - backend when it should be in the primitives? - Intent ------ * What is the change being proposed? * Do we want this feature or is the bug they're fixing really a bug? +Architecture +------------ + +* Is the proposed change being made in the correct place? Is it a fix in a + backend when it should be in the primitives? + Implementation -------------- |