Merge pull request #1931 from reaperhulk/aki-eq

add eq/ne methods for AuthorityKeyIdentifier

2 files changed, 43 insertions, 0 deletions

diff --git a/src/cryptography/x509.py b/src/cryptography/x509.py
index cdddfb57..173fd084 100644
--- a/src/cryptography/x509.py
+++ b/src/cryptography/x509.py
@@ -950,6 +950,20 @@ class AuthorityKeyIdentifier(object):
             ")>".format(self)
         )
 
+    def __eq__(self, other):
+        if not isinstance(other, AuthorityKeyIdentifier):
+            return NotImplemented
+
+        return (
+            self.key_identifier == other.key_identifier and
+            self.authority_cert_issuer == other.authority_cert_issuer and
+            self.authority_cert_serial_number ==
+            other.authority_cert_serial_number
+        )
+
+    def __ne__(self, other):
+        return not self == other
+
     key_identifier = utils.read_only_property("_key_identifier")
     authority_cert_issuer = utils.read_only_property("_authority_cert_issuer")
     authority_cert_serial_number = utils.read_only_property(
diff --git a/tests/test_x509_ext.py b/tests/test_x509_ext.py
index f07792d5..a366265c 100644
--- a/tests/test_x509_ext.py
+++ b/tests/test_x509_ext.py
@@ -473,6 +473,35 @@ class TestAuthorityKeyIdentifier(object):
                 "])>)>], authority_cert_serial_number=1234)>"
             )
 
+    def test_eq(self):
+        dirname = x509.DirectoryName(
+            x509.Name([x509.NameAttribute(x509.OID_COMMON_NAME, 'myCN')])
+        )
+        aki = x509.AuthorityKeyIdentifier(b"digest", [dirname], 1234)
+        dirname2 = x509.DirectoryName(
+            x509.Name([x509.NameAttribute(x509.OID_COMMON_NAME, 'myCN')])
+        )
+        aki2 = x509.AuthorityKeyIdentifier(b"digest", [dirname2], 1234)
+        assert aki == aki2
+
+    def test_ne(self):
+        dirname = x509.DirectoryName(
+            x509.Name([x509.NameAttribute(x509.OID_COMMON_NAME, 'myCN')])
+        )
+        dirname5 = x509.DirectoryName(
+            x509.Name([x509.NameAttribute(x509.OID_COMMON_NAME, 'aCN')])
+        )
+        aki = x509.AuthorityKeyIdentifier(b"digest", [dirname], 1234)
+        aki2 = x509.AuthorityKeyIdentifier(b"diges", [dirname], 1234)
+        aki3 = x509.AuthorityKeyIdentifier(b"digest", None, None)
+        aki4 = x509.AuthorityKeyIdentifier(b"digest", [dirname], 12345)
+        aki5 = x509.AuthorityKeyIdentifier(b"digest", [dirname5], 12345)
+        assert aki != aki2
+        assert aki != aki3
+        assert aki != aki4
+        assert aki != aki5
+        assert aki != object()
+
 
 class TestBasicConstraints(object):
     def test_ca_not_boolean(self):