aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Gaynor <alex.gaynor@gmail.com>2015-03-03 23:36:54 -0500
committerAlex Gaynor <alex.gaynor@gmail.com>2015-03-03 23:36:54 -0500
commitc21c4af1868791c2160280b51c6abbb4dcd70a73 (patch)
tree46190beb2921a79982bd795d4300e9ed92c5a225
parent71445561bf0b685ab3d69e441caf81940e9cad4e (diff)
parentd39c560471422b5b0f6d9000bfa0af987cd04d67 (diff)
downloadcryptography-c21c4af1868791c2160280b51c6abbb4dcd70a73.tar.gz
cryptography-c21c4af1868791c2160280b51c6abbb4dcd70a73.tar.bz2
cryptography-c21c4af1868791c2160280b51c6abbb4dcd70a73.zip
Merge pull request #1720 from reaperhulk/gcc-old-openssl-match-made-in-hell
Revert "simplify our DSA parameter copying"
-rw-r--r--src/cryptography/hazmat/backends/openssl/backend.py5
-rw-r--r--src/cryptography/hazmat/bindings/openssl/dsa.py2
2 files changed, 4 insertions, 3 deletions
diff --git a/src/cryptography/hazmat/backends/openssl/backend.py b/src/cryptography/hazmat/backends/openssl/backend.py
index c807b629..de653032 100644
--- a/src/cryptography/hazmat/backends/openssl/backend.py
+++ b/src/cryptography/hazmat/backends/openssl/backend.py
@@ -602,9 +602,12 @@ class Backend(object):
return _DSAParameters(self, ctx)
def generate_dsa_private_key(self, parameters):
- ctx = self._lib.DSAparams_dup(parameters._dsa_cdata)
+ ctx = self._lib.DSA_new()
assert ctx != self._ffi.NULL
ctx = self._ffi.gc(ctx, self._lib.DSA_free)
+ ctx.p = self._lib.BN_dup(parameters._dsa_cdata.p)
+ ctx.q = self._lib.BN_dup(parameters._dsa_cdata.q)
+ ctx.g = self._lib.BN_dup(parameters._dsa_cdata.g)
self._lib.DSA_generate_key(ctx)
diff --git a/src/cryptography/hazmat/bindings/openssl/dsa.py b/src/cryptography/hazmat/bindings/openssl/dsa.py
index 4261d4bd..99a685df 100644
--- a/src/cryptography/hazmat/bindings/openssl/dsa.py
+++ b/src/cryptography/hazmat/bindings/openssl/dsa.py
@@ -48,8 +48,6 @@ int DSA_verify(int, const unsigned char *, int, const unsigned char *, int,
MACROS = """
int DSA_generate_parameters_ex(DSA *, int, unsigned char *, int,
int *, unsigned long *, BN_GENCB *);
-// This is a macro in OpenSSL < 1.0.0
-DSA *DSAparams_dup(DSA *);
"""
CUSTOMIZATIONS = """