aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Kehrer <paul.l.kehrer@gmail.com>2014-02-25 23:05:54 -0600
committerPaul Kehrer <paul.l.kehrer@gmail.com>2014-02-25 23:05:54 -0600
commita0c157f467536b556481f7c2ee950612f4f8f7e7 (patch)
tree6c83bf461049a48f4e5ae62198e13f4bf959282f
parentdc720296556645f0641907e3618f6a1613c39fe7 (diff)
downloadcryptography-a0c157f467536b556481f7c2ee950612f4f8f7e7.tar.gz
cryptography-a0c157f467536b556481f7c2ee950612f4f8f7e7.tar.bz2
cryptography-a0c157f467536b556481f7c2ee950612f4f8f7e7.zip
fix docs, port some review comments forward to the new PR
-rw-r--r--cryptography/hazmat/backends/openssl/backend.py6
-rw-r--r--docs/hazmat/primitives/asymmetric/rsa.rst39
2 files changed, 24 insertions, 21 deletions
diff --git a/cryptography/hazmat/backends/openssl/backend.py b/cryptography/hazmat/backends/openssl/backend.py
index d080cc8a..0c4fbc3e 100644
--- a/cryptography/hazmat/backends/openssl/backend.py
+++ b/cryptography/hazmat/backends/openssl/backend.py
@@ -706,7 +706,7 @@ class _RSAVerificationContext(object):
self._signature = signature
if not isinstance(padding, interfaces.AsymmetricPadding):
raise TypeError(
- "Expected interface of interfaces.AsymmetricPadding")
+ "Expected provider of interfaces.AsymmetricPadding")
if padding.name == "EMSA-PKCS1-v1_5":
if self._backend._lib.Cryptography_HAS_PKEY_CTX:
@@ -723,13 +723,13 @@ class _RSAVerificationContext(object):
def update(self, data):
if self._hash_ctx is None:
- raise AlreadyFinalized("Context was already finalized")
+ raise AlreadyFinalized("Context has already been finalized")
self._hash_ctx.update(data)
def verify(self):
if self._hash_ctx is None:
- raise AlreadyFinalized("Context was already finalized")
+ raise AlreadyFinalized("Context has already been finalized")
evp_pkey = self._backend._lib.EVP_PKEY_new()
assert evp_pkey != self._backend._ffi.NULL
diff --git a/docs/hazmat/primitives/asymmetric/rsa.rst b/docs/hazmat/primitives/asymmetric/rsa.rst
index 198ed7a3..b3119440 100644
--- a/docs/hazmat/primitives/asymmetric/rsa.rst
+++ b/docs/hazmat/primitives/asymmetric/rsa.rst
@@ -115,22 +115,8 @@ RSA
.. versionadded:: 0.3
- :param bytes signature: The signature to verify.
-
- :param padding: An instance of a
- :class:`~cryptography.hazmat.primitives.interfaces.AsymmetricPadding`
- provider.
-
- :param algorithm: An instance of a
- :class:`~cryptography.hazmat.primitives.interfaces.HashAlgorithm`
- provider.
-
- :param backend: A
- :class:`~cryptography.hazmat.backends.interfaces.RSABackend`
- provider.
-
- :returns:
- :class:`~cryptography.hazmat.primitives.interfaces.AsymmetricVerificationContext`
+ Verify data was signed by the private key associated with the public
+ key.
.. doctest::
@@ -142,15 +128,32 @@ RSA
... key_size=2048,
... backend=default_backend()
... )
- >>> signer = private_key.signer(padding.PKCS1(), hashes.SHA256(), default_backend())
+ >>> signer = private_key.signer(padding.PKCS1v15(), hashes.SHA256(), default_backend())
>>> data= b"this is some data I'd like to sign"
>>> signer.update(data)
>>> signature = signer.finalize()
>>> public_key = private_key.public_key()
- >>> verifier = public_key.verifier(signature, padding.PKCS1(), hashes.SHA256(), default_backend())
+ >>> verifier = public_key.verifier(signature, padding.PKCS1v15(), hashes.SHA256(), default_backend())
>>> verifier.update(data)
>>> verifier.verify()
+ :param bytes signature: The signature to verify.
+
+ :param padding: An instance of a
+ :class:`~cryptography.hazmat.primitives.interfaces.AsymmetricPadding`
+ provider.
+
+ :param algorithm: An instance of a
+ :class:`~cryptography.hazmat.primitives.interfaces.HashAlgorithm`
+ provider.
+
+ :param backend: A
+ :class:`~cryptography.hazmat.backends.interfaces.RSABackend`
+ provider.
+
+ :returns:
+ :class:`~cryptography.hazmat.primitives.interfaces.AsymmetricVerificationContext`
+
.. _`RSA`: https://en.wikipedia.org/wiki/RSA_(cryptosystem)
.. _`public-key`: https://en.wikipedia.org/wiki/Public-key_cryptography
.. _`use 65537`: http://www.daemonology.net/blog/2009-06-11-cryptographic-right-answers.html