aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Gaynor <alex.gaynor@gmail.com>2014-02-13 12:48:46 -0800
committerAlex Gaynor <alex.gaynor@gmail.com>2014-02-13 12:48:46 -0800
commit86dc3ab8e849498471f8f5b65470c7a53d4023e7 (patch)
tree4dfd31c89d0376f5a0b8b909835d173ca55ca542
parent811163e609c2df4f785473376f914d224d896f07 (diff)
downloadcryptography-86dc3ab8e849498471f8f5b65470c7a53d4023e7.tar.gz
cryptography-86dc3ab8e849498471f8f5b65470c7a53d4023e7.tar.bz2
cryptography-86dc3ab8e849498471f8f5b65470c7a53d4023e7.zip
Fix comments in padding.py to be accurate
This is not in fact O(n ** 2) because ``len(self._buffer)`` is bounded by ``self.block_size``. This means that each ``self._buffer += x`` only copies O(len(x)) bytes, meaning the whole thing is linear.
-rw-r--r--cryptography/hazmat/primitives/padding.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/cryptography/hazmat/primitives/padding.py b/cryptography/hazmat/primitives/padding.py
index ddb2c63c..1717262c 100644
--- a/cryptography/hazmat/primitives/padding.py
+++ b/cryptography/hazmat/primitives/padding.py
@@ -86,8 +86,7 @@ class PKCS7(object):
class _PKCS7PaddingContext(object):
def __init__(self, block_size):
self.block_size = block_size
- # TODO: O(n ** 2) complexity for repeated concatentation, we should use
- # zero-buffer (#193)
+ # TODO: more copies than necessary, we should use zero-buffer (#193)
self._buffer = b""
def update(self, data):
@@ -120,8 +119,7 @@ class _PKCS7PaddingContext(object):
class _PKCS7UnpaddingContext(object):
def __init__(self, block_size):
self.block_size = block_size
- # TODO: O(n ** 2) complexity for repeated concatentation, we should use
- # zero-buffer (#193)
+ # TODO: more copies than necessary, we should use zero-buffer (#193)
self._buffer = b""
def update(self, data):