| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Fix documentation. This address https://github.com/google/googletest/pull/2827.
PiperOrigin-RevId: 309241571
|
|\
| |
| |
| | |
PiperOrigin-RevId: 308711492
|
|\|
| |
| |
| | |
PiperOrigin-RevId: 308650221
|
| | |
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 308625388
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
googletest-param-test-test.cc:502:8: error:
definition of implicit copy constructor for
'NonDefaultConstructAssignString' is deprecated because it has a
user-declared copy assignment operator [-Werror,-Wdeprecated]
void operator=(const NonDefaultConstructAssignString&);
^
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
googletest-port-test.cc:97:11: error:
definition of implicit copy constructor for 'Base' is deprecated because
it has a user-declared destructor [-Werror,-Wdeprecated]
virtual ~Base() {}
^
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
None of these are strictly needed for correctness.
A large number of them (maybe all of them?) trigger `-Wdeprecated`
warnings on Clang trunk as soon as you try to use the implicitly
defaulted (but deprecated) copy constructor of a class that has
deleted its copy assignment operator.
By declaring a deleted copy assignment operator, the old code
also caused the move constructor and move assignment operator
to be non-declared. This means that the old code never got move
semantics -- "move-construction" would simply call the defaulted
(but deprecated) copy constructor instead. With the new code,
"move-construction" calls the defaulted move constructor, which
I believe is what we want to happen. So this is a runtime
performance optimization.
Unfortunately we can't yet physically remove the definitions
of these macros from gtest-port.h, because they are being used
by other code internally at Google (according to zhangxy988).
But no new uses should be added going forward.
|
| |
| |
| |
| |
| |
| | |
Use InitGoogleTest() instead of InitGoogle() in code example
PiperOrigin-RevId: 308070819
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Explicitly define copy constructors used in googletest tests
As of C++11, providing a user-declared copy assignment operator should
suppress the availability of an implicit default copy constructor.
Classes that provide (or delete) a copy assignment operator must provide
their own copy constructor if one is desired. This may be an explicit
default copy constructor if appropriate.
As googletest is a C++11 codebase, this change should be made without
qualification.
This addresses the -Wdeprecated-copy warnings issued by trunk clang:
While compiling googletest/test/googletest-death-test-test.cc:
In file included from .../googletest/test/googletest-death-test-test.cc:33:
.../googletest/include/gtest/gtest-death-test.h:196:8: error: definition of implicit copy constructor for 'ExitedWithCode' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
void operator=(const ExitedWithCode& other);
^
.../googletest/test/googletest-death-test-test.cc:279:16: note: in implicit copy constructor for 'testing::ExitedWithCode' first required here
EXPECT_PRED1(pred0, status0);
^
While compiling googletest/test/googletest-param-test-test.cc:
.../googletest/test/googletest-param-test-test.cc:502:8: error: definition of implicit copy constructor for 'NonDefaultConstructAssignString' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
void operator=(const NonDefaultConstructAssignString&);
^
.../googletest/test/googletest-param-test-test.cc:507:36: note: in implicit copy constructor for 'NonDefaultConstructAssignString' first required here
Combine(Values(0, 1), Values(NonDefaultConstructAssignString("A"),
This matches other changes made elsewhere in the googletest codebase,
such as 306f3754a71d. Perhaps those previous changes did not consider
test code.
PiperOrigin-RevId: 307495126
|
|/
|
|
|
|
| |
Internal change
PiperOrigin-RevId: 307040308
|
|\
| |
| |
| | |
PiperOrigin-RevId: 306462650
|
| | |
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 306460942
|
| |/ |
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 306460738
|
| |/ |
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 305747437
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Google Test and Google Mock require matching versions to work,
so this requirement should be described in the pkgconfig files.
This change is derived from the one used for the Fedora gtest package.
Signed-off-by: Neal Gompa <ngompa13@gmail.com>
|
|\ \ \
| |_|/
|/| |
| | | |
PiperOrigin-RevId: 305707266
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes a -Wdeprecated warning.
/home/travis/build/Quuxplusone/googletest/googletest/test/googletest-death-test_ex_test.cc:62:28: error:
dynamic exception specifications are deprecated [-Werror,-Wdeprecated]
const char* what() const throw() override { return "exceptional message"; }
^~~~~~~
/home/travis/build/Quuxplusone/googletest/googletest/test/googletest-death-test_ex_test.cc:62:28: note:
use 'noexcept' instead
const char* what() const throw() override { return "exceptional message"; }
^~~~~~~
noexcept
|
|\ \ \
| | | |
| | | |
| | | | |
PiperOrigin-RevId: 304617903
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
PiperOrigin-RevId: 304613137
|
| | |_|/
| |/| |
| | | |
| | | | |
Fixes #2760.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This change updates testing::internal::IsAProtocolMessage to return true not
just for full proto messages but also for lite ones (i.e. those inheriting
directly from MessageLite).
PiperOrigin-RevId: 304286535
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
PiperOrigin-RevId: 303742575
|
| |/ / / |
|
|\ \ \ \
| |_|_|/
|/| | |
| | | | |
PiperOrigin-RevId: 303414597
|
| |/ / |
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add --gtest_fail_fast support to googletest.
- Analogous functionality to to golang -test.failfast and python --failfast
- Stops test execution upon first test failure.
- Also add support Bazel equivalent env var (TESTBRIDGE_TEST_RUNNER_FAIL_FAST)
PiperOrigin-RevId: 302488880
|
|\ \
| | |
| | |
| | | |
PiperOrigin-RevId: 302045808
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Exposition of the problem:
> cat main.cpp
TEST(errnoTest, errnoTest)
{
ASSERT_EQ(errno, 0);
}
int main(int argc, char** argv)
{
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}
Compiled with gcc 10 like this:
> g++ -pthread -o runtest main.cpp -Wl,-Bstatic -lgtest -Wl,-Bdynamic
Before patch:
> ./runtest
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from errnoTest
[ RUN ] errnoTest.errnoTest
[ OK ] errnoTest.errnoTest (0 ms)
[----------] 1 test from errnoTest (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[ PASSED ] 1 test.
(output is colored, I run this inside an interactive terminal).
> ./runtest | cat
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from errnoTest
[ RUN ] errnoTest.errnoTest
main.cpp:5: Failure
Expected equality of these values:
(*__errno_location ())
Which is: 25
0
[ FAILED ] errnoTest.errnoTest (0 ms)
[----------] 1 test from errnoTest (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] errnoTest.errnoTest
1 FAILED TEST
(output is not colored, since IsTTY return false, because of the pipe,
however it also clobbered errno for the tests).
After the patch, both cases are working fine:
> ./runtest
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from errnoTest
[ RUN ] errnoTest.errnoTest
[ OK ] errnoTest.errnoTest (0 ms)
[----------] 1 test from errnoTest (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[ PASSED ] 1 test.
> ./runtest | cat
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from errnoTest
[ RUN ] errnoTest.errnoTest
[ OK ] errnoTest.errnoTest (0 ms)
[----------] 1 test from errnoTest (0 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (0 ms total)
[ PASSED ] 1 test.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Move internal function out of header because Hyrum's law always wins.
PiperOrigin-RevId: 301446904
|
| | |
| | |
| | |
| | |
| | |
| | | |
Internal change
PiperOrigin-RevId: 299345492
|
| | |
| | |
| | |
| | |
| | |
| | | |
Simplify the fallback printing logic to have a single sequence of trial printers.
PiperOrigin-RevId: 298621376
|
|\ \ \
| | | |
| | | |
| | | | |
PiperOrigin-RevId: 298608772
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | |
| | | | |
PiperOrigin-RevId: 298599235
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rename internal color enumerators to avoid conflicts with curses.h macro definitions.
Fixes #2685
PiperOrigin-RevId: 297639382
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add gmock Matcher<std::string_view> specialization.
PiperOrigin-RevId: 294443240
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Refactor function GetNextPrime so that the loop precondition is checked before
loop instead of during every loop run. Also by removing the loop condition,
it shows that the only exit from the loop is the return statement.
PiperOrigin-RevId: 293932783
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Disable warning C4800 for Visual Studio 2019.
The compiler warning C4800 is disabled by default in Visual Studio 2019,
but it can be enabled on the command line. The only version of
Visual Studio that does not support warning C4800 is Visual Studio 2017.
PiperOrigin-RevId: 292624510
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add documentation for ASSERT_DEBUG_DEATH/EXPECT_DEBUG_DEATH
PiperOrigin-RevId: 292138974
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds missing `#define` guard around `TEST_F(...)`
PiperOrigin-RevId: 291703056
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Deleted an orphaned duplicate file and exclude another that shouldn't be part of :gtest_all_test.
This showed up while trying to debug the presubmit failure for: https://github.com/google/googletest/pull/2683
PiperOrigin-RevId: 291398123
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fix SCOPED_TRACE() message header in example
PiperOrigin-RevId: 290800241
|
| | |
| | |
| | |
| | |
| | |
| | | |
Add extra filtering so that the reported message differentiates between the case where INSTANTIATE_TEST_SUITE_P is missing vs. the case where TEST_P is missing.
PiperOrigin-RevId: 290114508
|
| | |
| | |
| | |
| | |
| | |
| | | |
Correct the spelling of PARAMETERIZED.
PiperOrigin-RevId: 289897278
|