aboutsummaryrefslogtreecommitdiffstats
path: root/googletest
Commit message (Collapse)AuthorAgeFilesLines
* Remove all uses of GTEST_DISALLOW_{MOVE_,}ASSIGN_.Arthur O'Dwyer2020-04-233-8/+2
| | | | | | | | | | | | | | | | | | | | | | None of these are strictly needed for correctness. A large number of them (maybe all of them?) trigger `-Wdeprecated` warnings on Clang trunk as soon as you try to use the implicitly defaulted (but deprecated) copy constructor of a class that has deleted its copy assignment operator. By declaring a deleted copy assignment operator, the old code also caused the move constructor and move assignment operator to be non-declared. This means that the old code never got move semantics -- "move-construction" would simply call the defaulted (but deprecated) copy constructor instead. With the new code, "move-construction" calls the defaulted move constructor, which I believe is what we want to happen. So this is a runtime performance optimization. Unfortunately we can't yet physically remove the definitions of these macros from gtest-port.h, because they are being used by other code internally at Google (according to zhangxy988). But no new uses should be added going forward.
* Merge pull request #2805 from pepsiman:patch-1Mark Barolak2020-04-161-1/+1
|\ | | | | | | PiperOrigin-RevId: 306462650
| * Remove redundant .c_str()Malcolm Parsons2020-04-091-1/+1
| |
* | Merge pull request #2802 from e-i-n-s:fix_clang_warningMark Barolak2020-04-161-4/+4
|\ \ | | | | | | | | | PiperOrigin-RevId: 306460942
| * | gtest-unittest-api_test - fix warning in clang buildMarco Studerus2020-04-061-4/+4
| |/
* | Merge pull request #2810 from ptahmose:masterMark Barolak2020-04-161-1/+1
|\ \ | | | | | | | | | PiperOrigin-RevId: 306460738
| * | fix signed/unsigned comparison issue (on OpenBSD)Juergen Bohl2020-04-121-1/+1
| |/
* | Merge pull request #2756 from Conan-Kudo:fix-pkgconfig-reqsMark Barolak2020-04-161-1/+1
|\ \ | | | | | | | | | PiperOrigin-RevId: 305747437
| * | Ensure that gtest/gmock pkgconfig requirements specify versionNeal Gompa2020-03-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Google Test and Google Mock require matching versions to work, so this requirement should be described in the pkgconfig files. This change is derived from the one used for the Fedora gtest package. Signed-off-by: Neal Gompa <ngompa13@gmail.com>
* | | Merge pull request #2773 from Quuxplusone:replace-noexceptMark Barolak2020-04-161-1/+1
|\ \ \ | |_|/ |/| | | | | PiperOrigin-RevId: 305707266
| * | Replace the last instance of `throw()` with `noexcept`. NFC.Arthur O'Dwyer2020-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a -Wdeprecated warning. /home/travis/build/Quuxplusone/googletest/googletest/test/googletest-death-test_ex_test.cc:62:28: error: dynamic exception specifications are deprecated [-Werror,-Wdeprecated] const char* what() const throw() override { return "exceptional message"; } ^~~~~~~ /home/travis/build/Quuxplusone/googletest/googletest/test/googletest-death-test_ex_test.cc:62:28: note: use 'noexcept' instead const char* what() const throw() override { return "exceptional message"; } ^~~~~~~ noexcept
* | | Merge pull request #2715 from kuzkry:document-premature-exit-file-protocolAndy Getz2020-04-041-0/+12
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 304617903
| * | | add documentation for the premature-exit-file protocolKrystian Kuzniarek2019-11-111-0/+12
| | | |
* | | | Merge pull request #2762 from pkryger:avoid_sigprofAndy Getz2020-04-041-5/+7
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 304613137
| * | | | Swap settimer and sigaction calls to avoid SIGPROFPrzemek Kryger2020-03-241-5/+7
| | |_|/ | |/| | | | | | | | | | Fixes #2760.
* | | | Googletest exportAbseil Team2020-04-042-5/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change updates testing::internal::IsAProtocolMessage to return true not just for full proto messages but also for lite ones (i.e. those inheriting directly from MessageLite). PiperOrigin-RevId: 304286535
* | | | Merge pull request #2765 from kuzkry:unsupported-build-systemsAndy Getz2020-03-311-71/+0
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 303742575
| * | | | remove chapters on Autotools, Meson and plain MakefilesKrystian Kuzniarek2020-03-241-71/+0
| |/ / /
* | | | Merge pull request #2764 from kuzkry:googletest-output-test-dead-codeAndy Getz2020-03-311-57/+0
|\ \ \ \ | |_|_|/ |/| | | | | | | PiperOrigin-RevId: 303414597
| * | | remove dead code in googletest-output-testKrystian Kuzniarek2020-03-241-57/+0
| |/ /
* / / Googletest exportAbseil Team2020-03-2410-54/+784
|/ / | | | | | | | | | | | | | | | | | | Add --gtest_fail_fast support to googletest. - Analogous functionality to to golang -test.failfast and python --failfast - Stops test execution upon first test failure. - Also add support Bazel equivalent env var (TESTBRIDGE_TEST_RUNNER_FAIL_FAST) PiperOrigin-RevId: 302488880
* | Merge pull request #2746 from Romain-Geissler-1A:mastervslashg2020-03-201-5/+18
|\ \ | | | | | | | | | PiperOrigin-RevId: 302045808
| * | Make sure IsATTY does not clobber errno.Romain Geissler2020-03-111-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Exposition of the problem: > cat main.cpp TEST(errnoTest, errnoTest) { ASSERT_EQ(errno, 0); } int main(int argc, char** argv) { ::testing::InitGoogleTest(&argc, argv); return RUN_ALL_TESTS(); } Compiled with gcc 10 like this: > g++ -pthread -o runtest main.cpp -Wl,-Bstatic -lgtest -Wl,-Bdynamic Before patch: > ./runtest [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from errnoTest [ RUN ] errnoTest.errnoTest [ OK ] errnoTest.errnoTest (0 ms) [----------] 1 test from errnoTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 1 test. (output is colored, I run this inside an interactive terminal). > ./runtest | cat [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from errnoTest [ RUN ] errnoTest.errnoTest main.cpp:5: Failure Expected equality of these values: (*__errno_location ()) Which is: 25 0 [ FAILED ] errnoTest.errnoTest (0 ms) [----------] 1 test from errnoTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] errnoTest.errnoTest 1 FAILED TEST (output is not colored, since IsTTY return false, because of the pipe, however it also clobbered errno for the tests). After the patch, both cases are working fine: > ./runtest [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from errnoTest [ RUN ] errnoTest.errnoTest [ OK ] errnoTest.errnoTest (0 ms) [----------] 1 test from errnoTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 1 test. > ./runtest | cat [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from errnoTest [ RUN ] errnoTest.errnoTest [ OK ] errnoTest.errnoTest (0 ms) [----------] 1 test from errnoTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 1 test.
* | | Googletest exportAbseil Team2020-03-172-6/+4
| | | | | | | | | | | | | | | | | | Move internal function out of header because Hyrum's law always wins. PiperOrigin-RevId: 301446904
* | | Googletest exportAbseil Team2020-03-171-2/+0
| | | | | | | | | | | | | | | | | | Internal change PiperOrigin-RevId: 299345492
* | | Googletest exportAbseil Team2020-03-172-259/+160
| | | | | | | | | | | | | | | | | | Simplify the fallback printing logic to have a single sequence of trial printers. PiperOrigin-RevId: 298621376
* | | Merge pull request #2722 from JohanMabille:warningsvslashg2020-03-171-1/+1
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 298608772
| * | | Fixed warningsJohan Mabille2020-02-211-1/+1
| | | |
* | | | Merge pull request #2716 from kuzkry:autotools-leftovervslashg2020-03-171-3/+3
|\ \ \ \ | |_|/ / |/| | | | | | | PiperOrigin-RevId: 298599235
| * | | remove a dead reference to the Autotools scriptKrystian Kuzniarek2020-01-291-3/+3
| | | |
* | | | Googletest exportAbseil Team2020-02-282-47/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename internal color enumerators to avoid conflicts with curses.h macro definitions. Fixes #2685 PiperOrigin-RevId: 297639382
* | | | Googletest exportAbseil Team2020-02-115-50/+82
| | | | | | | | | | | | | | | | | | | | | | | | Add gmock Matcher<std::string_view> specialization. PiperOrigin-RevId: 294443240
* | | | Googletest exportAbseil Team2020-02-111-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor function GetNextPrime so that the loop precondition is checked before loop instead of during every loop run. Also by removing the loop condition, it shows that the only exit from the loop is the return statement. PiperOrigin-RevId: 293932783
* | | | Googletest exportAbseil Team2020-02-071-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disable warning C4800 for Visual Studio 2019. The compiler warning C4800 is disabled by default in Visual Studio 2019, but it can be enabled on the command line. The only version of Visual Studio that does not support warning C4800 is Visual Studio 2017. PiperOrigin-RevId: 292624510
* | | | Googletest exportAbseil Team2020-02-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Add documentation for ASSERT_DEBUG_DEATH/EXPECT_DEBUG_DEATH PiperOrigin-RevId: 292138974
* | | | Googletest exportAbseil Team2020-02-071-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | Adds missing `#define` guard around `TEST_F(...)` PiperOrigin-RevId: 291703056
* | | | Googletest exportAbseil Team2020-02-072-61/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | Deleted an orphaned duplicate file and exclude another that shouldn't be part of :gtest_all_test. This showed up while trying to debug the presubmit failure for: https://github.com/google/googletest/pull/2683 PiperOrigin-RevId: 291398123
* | | Googletest exportAbseil Team2020-01-211-1/+1
| | | | | | | | | | | | | | | | | | Fix SCOPED_TRACE() message header in example PiperOrigin-RevId: 290800241
* | | Googletest exportAbseil Team2020-01-214-10/+37
| | | | | | | | | | | | | | | | | | Add extra filtering so that the reported message differentiates between the case where INSTANTIATE_TEST_SUITE_P is missing vs. the case where TEST_P is missing. PiperOrigin-RevId: 290114508
* | | Googletest exportAbseil Team2020-01-165-9/+10
| | | | | | | | | | | | | | | | | | Correct the spelling of PARAMETERIZED. PiperOrigin-RevId: 289897278
* | | Googletest exportAbseil Team2020-01-163-1/+22
| | | | | | | | | | | | | | | | | | Wire up things to support marking a type paramaterized test as allowed to be un-instantiated. PiperOrigin-RevId: 289699939
* | | Googletest exportAbseil Team2020-01-168-1/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST to mark a paramaterized test as allowed to be un-instantiated. This allows test suites, that are defined in libraries and, for other reasons, get linked in (which should probably be avoided, but isn't always possible) to be marked as allowed to go uninstantiated. This can also be used to grandfather existing issues and expedite adoption of the checks with regards to new cases before they can be fixed. PiperOrigin-RevId: 289581573
* | | Googletest exportAbseil Team2020-01-161-1/+5
| | | | | | | | | | | | | | | | | | Change testing::TempDir() return value for Android PiperOrigin-RevId: 289102017
* | | Googletest exportAbseil Team2020-01-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Removing GTEST_API from TrueWithString. This type is only used in test code on one side of a DLL boundary so it is not necessary. PiperOrigin-RevId: 288927929
* | | Googletest exportAbseil Team2020-01-091-1/+1
| | | | | | | | | | | | | | | | | | | | | Close #2658 Mark test case destrucors as override. PiperOrigin-RevId: 288507991
* | | Merge pull request #2639 from trzecieu:trzeci/move_ctor_assignAndy Soffer2020-01-022-5/+21
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 286896167
| * | | Make move operation noexcept.Piotr Paczkowski (trzeci.eu)2019-12-201-2/+2
| | | |
| * | | Define default destructor for test classesPiotr Paczkowski (trzeci.eu)2019-12-201-0/+1
| | | |
| * | | Deleted functions as part of public interfacePiotr Paczkowski (trzeci.eu)2019-12-201-4/+4
| | | |
| * | | Review notes: Return T& from assignment operatorsPiotr Paczkowski (trzeci.eu)2019-12-201-2/+2
| | | |