aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Revert "Googletest export": disallow empty prefixShahbaz Youssefi2019-12-164-20/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 20b5b8ecc7a81d23b4716e22a2b35fd53379c8c6. Reason for revert: Breaks existing applications, such as ANGLE (angleproject.org), requires adding an extra prefix that needs to be typed for no reason (when testing from command line) and increases the logs' sizes by a non-trivial amount due to the very large number of tests ANGLE runs. Original commit message: Add a compile time check to ensure that the parameters to TEST_P and INSTANTIATE_TEST_SUITE_P are not empty. Some compilers already fail in that case and, even where it works, it's likely to result in technically invalid code by virtue of creating reserved identifiers: https://en.cppreference.com/w/cpp/language/identifiers First, every project is perfectly capable of adding a prefix if they want to support such a compiler. This change penalizes every project. Second, using a prefix such as `_p` also results in reserved identifiers, so this change is not really solving the problem. For that matter, instead of generating `gtest_##prefix##...`, you can generate `gtest_x##prefix##...` to correctly fix the issue, including when empty prefixes are used.
| * | | Revert "Googletest export": Remove test for empty prefixShahbaz Youssefi2019-12-163-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4c25e2b87fcb78abcfdee2739db9ed7a19754cd3. Reason for revert: Reverting the commit that disallows empty prefixes. Original commit message: Remove a test case rendered obsolete by disallowing empty argument for INSTANTIATE_TEST_SUITE_P. Remove the code that it was testing.
| * | | Workaround VS bug w.r.t empty arguments to macrosShahbaz Youssefi2019-12-161-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Empty arguments can be passed to macros per C99 and C++11 specs, which can then be forwarded to other macros. Visual Studio's compiler has a bug in the following situation: #define A(x) #x #define B(x, y) A(x) B(, b) In the above case, Visual Studio first expands x to nothing, then complains that A is not invoked with the right amount of arguments. However, x in A(x) is still one argument, even if it expands to no preprocessing tokens. See also https://stackoverflow.com/a/7674214.
* | | | Googletest exportAbseil Team2020-01-023-17/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use C++11 variadic templates for InvokeArgumentAdl in gmock-generated-actions.h. Make InvokeArgumentAdl use variadic templates to generate its overloads instead of using pump.py syntax. PiperOrigin-RevId: 286267615
* | | | Googletest exportAbseil Team2020-01-023-98/+17
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | Use C++11 variadic templates for InvokeArgumentAdl in gmock-generated-actions.h. Make InvokeArgumentAdl use variadic templates to generate its overloads instead of using pump.py syntax. PiperOrigin-RevId: 286148805
* | | Merge pull request #2590 from kuzkry:remove-workaround_g++-stale-commentsCJ Johnson2019-12-161-12/+0
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 285812343
| * | | remove stale comments about older GCC versionsKrystian Kuzniarek2019-11-221-12/+0
| | | |
* | | | Googletest exportkrzysio2019-12-161-18/+17
| |/ / |/| | | | | | | | | | | | | | | | | | | | Don't use fully qualified ::std types in code examples. Having a nested user-defined 'std' namespace anywhere in a program is a minefield and shouldn't be either explicitly supported or implicitly condoned. PiperOrigin-RevId: 285790182
* | | Merge pull request #2589 from ↵Matt Calabrese2019-12-131-9/+3
|\ \ \ | | | | | | | | | | | | | | | | | | | | kuzkry:remove-workaround_g++-no-space-after-first-macro-argument PiperOrigin-RevId: 285255373
| * | | remove g++ 2.95.0 workaround: no space after first comma in macrosKrystian Kuzniarek2019-11-221-9/+3
| |/ /
* | | Googletest exportAbseil Team2019-12-131-1/+2
| | | | | | | | | | | | | | | | | | Add GTEST_API_ to correct a build failure under MSCV. PiperOrigin-RevId: 285208464
* | | Googletest exportAbseil Team2019-12-133-175/+40
| | | | | | | | | | | | | | | | | | | | | | | | Use C++11 variadic templates for ActionHelper in gmock-generated-actions.h. Make ActionHelper use variadic templates to generate Perform static member function specializations instead of using pump.py syntax. PiperOrigin-RevId: 284988441
* | | Googletest exportAbseil Team2019-12-135-4/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detect when C++ parametric tests (TEST_P) are not instantiated. When an un-instantiated TEST_P is found, a new test will be inserted that will emit a warning message. This can be made to error with minor code edits. In the future, that is intended to be the default. PiperOrigin-RevId: 284901666
* | | Merge pull request #2595 from kuzkry:remove-workaround_msvc-warning-4355Matt Calabrese2019-12-131-8/+0
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 284234675
| * | | remove MSVC workaround: warning 4355Krystian Kuzniarek2019-11-221-8/+0
| |/ /
* | | Merge pull request #2592 from kuzkry:remove-workaround_msvc-error-C2665Matt Calabrese2019-12-131-9/+0
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 284207090
| * | | remove MSVC workaround: error C2665Krystian Kuzniarek2019-11-221-9/+0
| |/ /
* | / Googletest exportmisterg2019-12-131-0/+2
| |/ |/| | | | | | | | | Require all appveyor googletest windows builds to work on Pull Requests to increase CI coverage PiperOrigin-RevId: 284206759
* | Merge pull request #2609 from kuzkry:revert-2596Mark Barolak2019-12-062-11/+13
|\ \ | | | | | | | | | PiperOrigin-RevId: 284041013
| * | Revert "remove MSVC workaround: wmain link error in the static library"Krystian Kuzniarek2019-11-271-2/+9
| | | | | | | | | | | | This reverts commit 298a40f023e6813d2bf73847c3a38ceaf5e46320.
| * | Revert "unify googletest and googlemock main functions"Krystian Kuzniarek2019-11-272-9/+4
| | | | | | | | | | | | This reverts commit a909becdc599c46bcb57346b6123cb57cd07d15d.
* | | Googletest exportAbseil Team2019-12-066-31/+152
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change googletest to notice failures during SetUpTestSuite() and TearDownTestSuite(). Previously, errors that occurred during those functions were logged but otherwise ignored. After this change, such failures will cause the test to fail and a brief summary will be printed at the bottom of the test log. See https://github.com/google/googletest/issues/2330. PiperOrigin-RevId: 284033342
* | | Googletest exportAbseil Team2019-12-051-1/+1
| | | | | | | | | | | | | | | | | | Update example Environment class destructor annotation PiperOrigin-RevId: 283986183
* | | Merge pull request #2594 from ↵Mark Barolak2019-12-051-17/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | kuzkry:remove-workaround_msvc-unneeded-const-dropping PiperOrigin-RevId: 283979494
| * | | remove MSVC workaround: cease const droppingKrystian Kuzniarek2019-11-221-14/+3
| | |/ | |/|
* | | Googletest exportAbseil Team2019-12-051-1/+1
| | | | | | | | | | | | | | | | | | Internal change PiperOrigin-RevId: 283948137
* | | Googletest exportAbseil Team2019-12-021-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clarify use of IsTrue and IsFalse matchers. These matchers are subtle and confusing: what are they for? The docs in the code are clear, but not very accessible. googletest/googlemock/include/gmock/gmock-more-matchers.h PiperOrigin-RevId: 283393275
* | | Merge pull request #2603 from maximilianschwab:patch-1Mark Barolak2019-12-021-1/+1
|\ \ \ | | | | | | | | | | | | PiperOrigin-RevId: 283349646
| * | | Fixed typoMaximilian Schwab2019-11-251-1/+1
| | | |
* | | | Merge pull request #2607 from oyefremov:patch-1Mark Barolak2019-12-021-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 283349621
| * | | | Rename test case to test suiteOleksandr Yefremov2019-11-271-1/+1
| | |_|/ | |/| |
* | | | Merge pull request #2583 from ChristophStrehle:masterGennadiy Rozental2019-11-271-1/+2
|\ \ \ \ | |/ / / |/| | | | | | | PiperOrigin-RevId: 282817206
| * | | Fix compile break for Microsoft Visual Studio 2017 v141Christoph Strehle2019-11-211-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a workaround, for those who have to compile with v141 build tools, for a bug in msvc that the compiler can't compile the WithArgsAction. see the following link for more details: https://developercommunityapi.westus.cloudapp.azure.com/content/problem/420339/googlemocks-withargs-doesnt-compile-with-permissiv.html
* | | | Merge pull request #2604 from matepek:readme-update-with-opensource-projGennadiy Rozental2019-11-261-0/+4
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 282620313
| * | | | README.md: added Catch2 and Google Test ExplorerMate Pek2019-11-251-0/+4
| | |/ / | |/| |
* | | | Merge pull request #2593 from ↵Gennadiy Rozental2019-11-261-9/+4
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | kuzkry:remove-workaround_msvc-namespace-scope-from-nested-class PiperOrigin-RevId: 282593823
| * | | | remove MSVC workaround: accessing namespace scope from within nested classesKrystian Kuzniarek2019-11-221-9/+4
| | |_|/ | |/| |
* | | | Merge pull request #2596 from kuzkry:remove-workaround_msvc-wmain-link-errorGennadiy Rozental2019-11-262-13/+11
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 282589492
| * | | | unify googletest and googlemock main functionsKrystian Kuzniarek2019-11-222-4/+9
| | | | |
| * | | | remove MSVC workaround: wmain link error in the static libraryKrystian Kuzniarek2019-11-221-9/+2
| |/ / /
* | | | Merge pull request #2597 from ↵Gennadiy Rozental2019-11-261-49/+36
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | kuzkry:remove-workaround_Nokia-Sybian-SafeMatcherCastImpl PiperOrigin-RevId: 282581402
| * | | | remove Nokia's Symbian compiler workaround: SafeMatcherCastImplKrystian Kuzniarek2019-11-221-49/+36
| | | | |
| * | | | consistency fix for SafeMatcherCastImpl member functionsKrystian Kuzniarek2019-11-221-1/+1
| |/ / /
* | | | Googletest exportAbseil Team2019-11-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wrap call to std::numeric_limits<>::max into round braces to appease MSVC. Closes #2589 PiperOrigin-RevId: 282581361
* | | | Merge pull request #2591 from kuzkry:remove-workaround_g++-using-on-operator<<Gennadiy Rozental2019-11-261-4/+2
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 282575040
| * | | | remove g++ 3.3 workaround: using on operator<<Krystian Kuzniarek2019-11-221-4/+2
| |/ / /
* | | | Merge pull request #2588 from kuzkry:remove-workaround_g++-incorrect-commentsGennadiy Rozental2019-11-262-19/+13
|\ \ \ \ | | | | | | | | | | | | | | | PiperOrigin-RevId: 282568282
| * | | | change incorrect commentsKrystian Kuzniarek2019-11-052-19/+13
| |/ / /
* | / / Googletest exportAbseil Team2019-11-261-1/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | Make generating goldens work with Python 3 golden_file.write(output) fails with Python 3 with: TypeError: a bytes-like object is required, not 'str' PiperOrigin-RevId: 282316101
* | | Googletest exportAbseil Team2019-11-221-1/+1
| | | | | | | | | | | | | | | | | | Fix typo in the predicate assertion table. PiperOrigin-RevId: 281973457