diff options
| author | CJ Johnson <johnsoncj@google.com> | 2019-12-16 16:03:59 -0500 |
|---|---|---|
| committer | CJ Johnson <johnsoncj@google.com> | 2019-12-16 16:03:59 -0500 |
| commit | d166e09483845b9b6a658dccc3d3dbb293676b62 (patch) | |
| tree | 5f38f56049388d69fbbb17a979a2864d10759409 | |
| parent | 0a0c826629926bb688f17fc4380dace434b66cc4 (diff) | |
| parent | a91e4e73b70273deea43e693e615e56f89f68437 (diff) | |
| download | googletest-d166e09483845b9b6a658dccc3d3dbb293676b62.tar.gz googletest-d166e09483845b9b6a658dccc3d3dbb293676b62.tar.bz2 googletest-d166e09483845b9b6a658dccc3d3dbb293676b62.zip | |
Merge pull request #2590 from kuzkry:remove-workaround_g++-stale-comments
PiperOrigin-RevId: 285812343
| -rw-r--r-- | googletest/test/gtest_unittest.cc | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/googletest/test/gtest_unittest.cc b/googletest/test/gtest_unittest.cc index 7acc2280..d4cb0a1b 100644 --- a/googletest/test/gtest_unittest.cc +++ b/googletest/test/gtest_unittest.cc @@ -3075,8 +3075,6 @@ TEST_F(DoubleTest, EXPECT_NEAR) { EXPECT_NONFATAL_FAILURE(EXPECT_NEAR(1.0, 1.5, 0.25), // NOLINT "The difference between 1.0 and 1.5 is 0.5, " "which exceeds 0.25"); - // To work around a bug in gcc 2.95.0, there is intentionally no - // space after the first comma in the previous statement. } // Tests ASSERT_NEAR. @@ -3086,8 +3084,6 @@ TEST_F(DoubleTest, ASSERT_NEAR) { EXPECT_FATAL_FAILURE(ASSERT_NEAR(1.0, 1.5, 0.25), // NOLINT "The difference between 1.0 and 1.5 is 0.5, " "which exceeds 0.25"); - // To work around a bug in gcc 2.95.0, there is intentionally no - // space after the first comma in the previous statement. } // Tests the cases where DoubleLE() should succeed. @@ -3732,10 +3728,6 @@ TEST(AssertionTest, ASSERT_EQ) { TEST(AssertionTest, ASSERT_EQ_NULL) { // A success. const char* p = nullptr; - // Some older GCC versions may issue a spurious warning in this or the next - // assertion statement. This warning should not be suppressed with - // static_cast since the test verifies the ability to use bare NULL as the - // expected parameter to the macro. ASSERT_EQ(nullptr, p); // A failure. @@ -4459,10 +4451,6 @@ TEST(ExpectTest, EXPECT_EQ_Double) { TEST(ExpectTest, EXPECT_EQ_NULL) { // A success. const char* p = nullptr; - // Some older GCC versions may issue a spurious warning in this or the next - // assertion statement. This warning should not be suppressed with - // static_cast since the test verifies the ability to use bare NULL as the - // expected parameter to the macro. EXPECT_EQ(nullptr, p); // A failure. |