diff options
Diffstat (limited to 'googlemock')
| -rw-r--r-- | googlemock/include/gmock/gmock-matchers.h | 4 | ||||
| -rw-r--r-- | googlemock/src/gmock-internal-utils.cc | 19 | ||||
| -rw-r--r-- | googlemock/src/gmock-matchers.cc | 19 | ||||
| -rw-r--r-- | googlemock/test/gmock-matchers_test.cc | 29 | 
4 files changed, 22 insertions, 49 deletions
| diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h index 94c23d38..fc3fe3aa 100644 --- a/googlemock/include/gmock/gmock-matchers.h +++ b/googlemock/include/gmock/gmock-matchers.h @@ -3614,10 +3614,6 @@ BoundSecondMatcher<Tuple2Matcher, Second> MatcherBindSecond(    return BoundSecondMatcher<Tuple2Matcher, Second>(tm, second);  } -// Joins a vector of strings as if they are fields of a tuple; returns -// the joined string.  This function is exported for testing. -GTEST_API_ string JoinAsTuple(const Strings& fields); -  // Returns the description for a matcher defined using the MATCHER*()  // macro where the user-supplied description string is "", if  // 'negation' is false; otherwise returns the description of the diff --git a/googlemock/src/gmock-internal-utils.cc b/googlemock/src/gmock-internal-utils.cc index 91bf3fd9..658fa62d 100644 --- a/googlemock/src/gmock-internal-utils.cc +++ b/googlemock/src/gmock-internal-utils.cc @@ -47,6 +47,25 @@  namespace testing {  namespace internal { +// Joins a vector of strings as if they are fields of a tuple; returns +// the joined string. +GTEST_API_ std::string JoinAsTuple(const Strings& fields) { +  switch (fields.size()) { +    case 0: +      return ""; +    case 1: +      return fields[0]; +    default: +      std::string result = "(" + fields[0]; +      for (size_t i = 1; i < fields.size(); i++) { +        result += ", "; +        result += fields[i]; +      } +      result += ")"; +      return result; +  } +} +  // Converts an identifier name to a space-separated list of lower-case  // words.  Each maximum substring of the form [A-Za-z][a-z]*|\d+ is  // treated as one word.  For example, both "FooBar123" and diff --git a/googlemock/src/gmock-matchers.cc b/googlemock/src/gmock-matchers.cc index 6e40e5e8..f37d5c2d 100644 --- a/googlemock/src/gmock-matchers.cc +++ b/googlemock/src/gmock-matchers.cc @@ -100,25 +100,6 @@ Matcher<StringPiece>::Matcher(StringPiece s) {  namespace internal { -// Joins a vector of strings as if they are fields of a tuple; returns -// the joined string. -GTEST_API_ string JoinAsTuple(const Strings& fields) { -  switch (fields.size()) { -    case 0: -      return ""; -    case 1: -      return fields[0]; -    default: -      string result = "(" + fields[0]; -      for (size_t i = 1; i < fields.size(); i++) { -        result += ", "; -        result += fields[i]; -      } -      result += ")"; -      return result; -  } -} -  // Returns the description for a matcher defined using the MATCHER*()  // macro where the user-supplied description string is "", if  // 'negation' is false; otherwise returns the description of the diff --git a/googlemock/test/gmock-matchers_test.cc b/googlemock/test/gmock-matchers_test.cc index 07e5fa63..761c0c22 100644 --- a/googlemock/test/gmock-matchers_test.cc +++ b/googlemock/test/gmock-matchers_test.cc @@ -146,7 +146,6 @@ using testing::internal::ExplainMatchFailureTupleTo;  using testing::internal::FloatingEqMatcher;  using testing::internal::FormatMatcherDescription;  using testing::internal::IsReadableTypeName; -using testing::internal::JoinAsTuple;  using testing::internal::linked_ptr;  using testing::internal::MatchMatrix;  using testing::internal::RE; @@ -872,9 +871,9 @@ class Unprintable {    char c_;  }; -inline bool operator==(const Unprintable& /* lhs */,  -                       const Unprintable& /* rhs */) {  -    return true;  +inline bool operator==(const Unprintable& /* lhs */, +                       const Unprintable& /* rhs */) { +    return true;  }  TEST(EqTest, CanDescribeSelf) { @@ -5268,28 +5267,6 @@ TEST(IsReadableTypeNameTest, ReturnsFalseForLongFunctionTypeNames) {    EXPECT_FALSE(IsReadableTypeName("void (&)(int, bool, char, float)"));  } -// Tests JoinAsTuple(). - -TEST(JoinAsTupleTest, JoinsEmptyTuple) { -  EXPECT_EQ("", JoinAsTuple(Strings())); -} - -TEST(JoinAsTupleTest, JoinsOneTuple) { -  const char* fields[] = {"1"}; -  EXPECT_EQ("1", JoinAsTuple(Strings(fields, fields + 1))); -} - -TEST(JoinAsTupleTest, JoinsTwoTuple) { -  const char* fields[] = {"1", "a"}; -  EXPECT_EQ("(1, a)", JoinAsTuple(Strings(fields, fields + 2))); -} - -TEST(JoinAsTupleTest, JoinsTenTuple) { -  const char* fields[] = {"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"}; -  EXPECT_EQ("(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)", -            JoinAsTuple(Strings(fields, fields + 10))); -} -  // Tests FormatMatcherDescription().  TEST(FormatMatcherDescriptionTest, WorksForEmptyDescription) { | 
