diff options
author | kosak <kosak@google.com> | 2014-01-12 23:42:34 +0000 |
---|---|---|
committer | kosak <kosak@google.com> | 2014-01-12 23:42:34 +0000 |
commit | 04ce8521f481d857db1aa00a206278759b9b0381 (patch) | |
tree | dfe2a98ae208ef6686fd8d424d5836ba98a32752 /include | |
parent | 18489fa4f81a65ab5f42a6705c28ca2f80eab3bd (diff) | |
download | googletest-04ce8521f481d857db1aa00a206278759b9b0381.tar.gz googletest-04ce8521f481d857db1aa00a206278759b9b0381.tar.bz2 googletest-04ce8521f481d857db1aa00a206278759b9b0381.zip |
Adds a note in the "uninteresting mock method call" warning to advise people how to handle the warning.
Clarifies the purpose of utilities in gmock-port.h and adds guidance w.r.t. gmock-port.h vs gtest-port.h.
Pulls in gtest r674.
Diffstat (limited to 'include')
-rw-r--r-- | include/gmock/internal/gmock-port.h | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/include/gmock/internal/gmock-port.h b/include/gmock/internal/gmock-port.h index b6c5c7f1..80ee2afc 100644 --- a/include/gmock/internal/gmock-port.h +++ b/include/gmock/internal/gmock-port.h @@ -30,8 +30,11 @@ // Author: vadimb@google.com (Vadim Berman) // // Low-level types and utilities for porting Google Mock to various -// platforms. They are subject to change without notice. DO NOT USE -// THEM IN USER CODE. +// platforms. All macros ending with _ and symbols defined in an +// internal namespace are subject to change without notice. Code +// outside Google Mock MUST NOT USE THEM DIRECTLY. Macros that don't +// end with _ are part of Google Mock's public API and can be used by +// code outside Google Mock. #ifndef GMOCK_INCLUDE_GMOCK_INTERNAL_GMOCK_PORT_H_ #define GMOCK_INCLUDE_GMOCK_INTERNAL_GMOCK_PORT_H_ @@ -40,8 +43,13 @@ #include <stdlib.h> #include <iostream> -// Most of the types needed for porting Google Mock are also required -// for Google Test and are defined in gtest-port.h. +// Most of the utilities needed for porting Google Mock are also +// required for Google Test and are defined in gtest-port.h. +// +// Note to maintainers: to reduce code duplication, prefer adding +// portability utilities to Google Test's gtest-port.h instead of +// here, as Google Mock depends on Google Test. Only add a utility +// here if it's truly specific to Google Mock. #include "gtest/internal/gtest-linked_ptr.h" #include "gtest/internal/gtest-port.h" |