diff options
author | Abseil Team <absl-team@google.com> | 2020-01-14 14:56:23 -0500 |
---|---|---|
committer | vslashg <gfalcon@google.com> | 2020-01-16 13:56:04 -0500 |
commit | 3e79d366e380ec85b7de9409211b184bc8529655 (patch) | |
tree | faab3a533deda76d3795cbf4702744abfba07111 /googletest/test | |
parent | 7a8591e6e4e206b748feb052f620c45278e686d0 (diff) | |
download | googletest-3e79d366e380ec85b7de9409211b184bc8529655.tar.gz googletest-3e79d366e380ec85b7de9409211b184bc8529655.tar.bz2 googletest-3e79d366e380ec85b7de9409211b184bc8529655.zip |
Googletest export
Wire up things to support marking a type paramaterized test as allowed to be un-instantiated.
PiperOrigin-RevId: 289699939
Diffstat (limited to 'googletest/test')
-rw-r--r-- | googletest/test/googletest-output-test-golden-lin.txt | 4 | ||||
-rw-r--r-- | googletest/test/googletest-param-test-test.cc | 10 |
2 files changed, 14 insertions, 0 deletions
diff --git a/googletest/test/googletest-output-test-golden-lin.txt b/googletest/test/googletest-output-test-golden-lin.txt index 72490816..a4a096e4 100644 --- a/googletest/test/googletest-output-test-golden-lin.txt +++ b/googletest/test/googletest-output-test-golden-lin.txt @@ -996,6 +996,10 @@ GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST(DetectNotInstantiatedTest); Type paramaterized test suite DetectNotInstantiatedTypesTest is defined via REGISTER_TYPED_TEST_SUITE_P, but never instantiated via INSTANTIATE_TYPED_TEST_SUITE_P. None of the test cases will run. Ideally, TYPED_TEST_P definitions should only ever be included as part of binaries that intend to use them. (As opposed to, for example, being placed in a library that may be linked in to get other utilities.) + +To suppress this error for this test suite, insert the following line (in a non-header) in the namespace it is definedin in: + +GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST(DetectNotInstantiatedTypesTest); [0;32m[ OK ] [mGoogleTestVerification.UninstantiatedTypeParamaterizedTestSuite<DetectNotInstantiatedTypesTest> [0;32m[----------] [mGlobal test environment tear-down BarEnvironment::TearDown() called. diff --git a/googletest/test/googletest-param-test-test.cc b/googletest/test/googletest-param-test-test.cc index b3b8140d..72a48375 100644 --- a/googletest/test/googletest-param-test-test.cc +++ b/googletest/test/googletest-param-test-test.cc @@ -1088,6 +1088,16 @@ TEST_P(NotInstantiatedTest, Used) { } using OtherName = NotInstantiatedTest; GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST(OtherName); TEST_P(OtherName, Used) { } + +// Used but not instantiated, this would fail. but... +template <typename T> +class NotInstantiatedTypeTest : public testing::Test {}; +TYPED_TEST_SUITE_P(NotInstantiatedTypeTest); +// ... we mark is as allowed. +GTEST_ALLOW_UNINSTANTIATED_PARAMTERIZED_TEST(NotInstantiatedTypeTest); + +TYPED_TEST_P(NotInstantiatedTypeTest, Used) { } +REGISTER_TYPED_TEST_SUITE_P(NotInstantiatedTypeTest, Used); } // namespace works_here int main(int argc, char **argv) { |