diff options
| author | Alexey Spiridonov <lesha@fb.com> | 2019-10-17 00:19:18 -0700 |
|---|---|---|
| committer | Alexey Spiridonov <snarkmaster@gmail.com> | 2019-10-17 00:32:47 -0700 |
| commit | cbf019de22c8dd37b2108da35b2748fd702d1796 (patch) | |
| tree | 5b36a0cb3f1b7d6879384f765cf9b324326a20ce /googletest/src | |
| parent | bdc29d5dc19dd802907ea37a80ce5dc9afe0898d (diff) | |
| download | googletest-cbf019de22c8dd37b2108da35b2748fd702d1796.tar.gz googletest-cbf019de22c8dd37b2108da35b2748fd702d1796.tar.bz2 googletest-cbf019de22c8dd37b2108da35b2748fd702d1796.zip | |
[googletest] Output skip message
Closes #2208
Previously, skip messages were invisible, so debugging skips was hard.
Now we have this:
```
$ ./googletest/gtest_skip_test
Running main() from /home/lesha/github/snarkmaster/googletest/googletest/src/gtest_main.cc
[==========] Running 3 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from SkipTest
[ RUN ] SkipTest.DoesSkip
/home/lesha/github/snarkmaster/googletest/googletest/test/gtest_skip_test.cc:38: Skipped
skipping single test
[ SKIPPED ] SkipTest.DoesSkip (0 ms)
[----------] 1 test from SkipTest (1 ms total)
...
```
Diffstat (limited to 'googletest/src')
| -rw-r--r-- | googletest/src/gtest.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index a5b4e5ac..6ddc5c80 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -3220,9 +3220,7 @@ void PrettyUnitTestResultPrinter::OnTestStart(const TestInfo& test_info) { void PrettyUnitTestResultPrinter::OnTestPartResult( const TestPartResult& result) { switch (result.type()) { - // If the test part succeeded, or was skipped, - // we don't need to do anything. - case TestPartResult::kSkip: + // If the test part succeeded, we don't need to do anything. case TestPartResult::kSuccess: return; default: |