aboutsummaryrefslogtreecommitdiffstats
path: root/googletest/cmake
diff options
context:
space:
mode:
authorEnji Cooper <yaneurabeya@gmail.com>2019-02-12 16:45:40 -0800
committerEnji Cooper <yaneurabeya@gmail.com>2019-02-12 16:45:40 -0800
commit1ded83195d938cef59b114316f4ccc11a625e132 (patch)
tree3a19eff6c40d7d1edee82d32278ef7c21a45ccd7 /googletest/cmake
parentc4ccab33aaa0e86741db7c02a1d1040af76bd059 (diff)
downloadgoogletest-1ded83195d938cef59b114316f4ccc11a625e132.tar.gz
googletest-1ded83195d938cef59b114316f4ccc11a625e132.tar.bz2
googletest-1ded83195d938cef59b114316f4ccc11a625e132.zip
Compile clang with `-Wall -Wshadow -Werror`
It was not compiling any of the code with warnings prior to this. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
Diffstat (limited to 'googletest/cmake')
-rw-r--r--googletest/cmake/internal_utils.cmake4
1 files changed, 4 insertions, 0 deletions
diff --git a/googletest/cmake/internal_utils.cmake b/googletest/cmake/internal_utils.cmake
index 489223a7..1909faf9 100644
--- a/googletest/cmake/internal_utils.cmake
+++ b/googletest/cmake/internal_utils.cmake
@@ -77,6 +77,10 @@ macro(config_compiler_and_linker)
# Suppress "unreachable code" warning
# http://stackoverflow.com/questions/3232669 explains the issue.
set(cxx_base_flags "${cxx_base_flags} -wd4702")
+ elseif (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
+ set(cxx_base_flags "-Wall -Wshadow -Werror")
+ set(cxx_exception_flags "-fexceptions")
+ set(cxx_no_exception_flags "-fno-exceptions")
elseif (CMAKE_COMPILER_IS_GNUCXX)
set(cxx_base_flags "-Wall -Wshadow -Werror")
if(NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 7.0.0)