aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHerbert Thielen <h-github@thielen-home.de>2017-08-30 10:43:54 +0200
committerGitHub <noreply@github.com>2017-08-30 10:43:54 +0200
commitc780e0e2c4e6d04a47d80068528471a9405c1665 (patch)
treee8f1d22a92effe5933ff733be0ede324ec20b673
parent8364718500dac72c141aa55dcb2483177356717d (diff)
parent71e2858f32902ca736e2dc8d81b512a4dfa18b80 (diff)
downloadgoogletest-c780e0e2c4e6d04a47d80068528471a9405c1665.tar.gz
googletest-c780e0e2c4e6d04a47d80068528471a9405c1665.tar.bz2
googletest-c780e0e2c4e6d04a47d80068528471a9405c1665.zip
Merge branch 'master' into hethi/travis-unused-cmake
-rw-r--r--.travis.yml7
-rw-r--r--README.md2
-rw-r--r--googlemock/docs/CookBook.md4
-rw-r--r--googletest/test/gtest_unittest.cc4
-rwxr-xr-xtravis.sh5
5 files changed, 9 insertions, 13 deletions
diff --git a/.travis.yml b/.travis.yml
index 3204dfac..c155e571 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -36,11 +36,8 @@ compiler:
script: ./travis.sh
env:
matrix:
- - GTEST_TARGET=googletest SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug VERBOSE_MAKE=true VERBOSE
- - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug VERBOSE_MAKE=true VERBOSE
- - GTEST_TARGET=googlemock SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug CXX_FLAGS=-std=c++11 VERBOSE_MAKE=true VERBOSE
-# - GTEST_TARGET=googletest SHARED_LIB=ON STATIC_LIB=ON CMAKE_PKG=ON BUILD_TYPE=release VERBOSE_MAKE=false
-# - GTEST_TARGET=googlemock SHARED_LIB=ON STATIC_LIB=ON CMAKE_PKG=ON BUILD_TYPE=release VERBOSE_MAKE=false
+ - SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug VERBOSE=1
+ - SHARED_LIB=OFF STATIC_LIB=ON CMAKE_PKG=OFF BUILD_TYPE=debug VERBOSE=1 CXX_FLAGS=-std=c++11
notifications:
email: false
sudo: false
diff --git a/README.md b/README.md
index 3efd2ebf..f858833d 100644
--- a/README.md
+++ b/README.md
@@ -26,7 +26,7 @@ in its interior [googletest/README.md](googletest/README.md) file.
## Features ##
- * An [XUnit](https://en.wikipedia.org/wiki/XUnit) test framework.
+ * An [xUnit](https://en.wikipedia.org/wiki/XUnit) test framework.
* Test discovery.
* A rich set of assertions.
* User-defined assertions.
diff --git a/googlemock/docs/CookBook.md b/googlemock/docs/CookBook.md
index 6ea7f3a9..753c6dd3 100644
--- a/googlemock/docs/CookBook.md
+++ b/googlemock/docs/CookBook.md
@@ -148,7 +148,7 @@ Note that the mock class doesn't define `AppendPacket()`, unlike the
real class. That's fine as long as the test doesn't need to call it.
Next, you need a way to say that you want to use
-`ConcretePacketStream` in production code, and use `MockPacketStream`
+`ConcretePacketStream` in production code and to use `MockPacketStream`
in tests. Since the functions are not virtual and the two classes are
unrelated, you must specify your choice at _compile time_ (as opposed
to run time).
@@ -706,7 +706,7 @@ type `m` accepts):
1. When both `T` and `U` are built-in arithmetic types (`bool`, integers, and floating-point numbers), the conversion from `T` to `U` is not lossy (in other words, any value representable by `T` can also be represented by `U`); and
1. When `U` is a reference, `T` must also be a reference (as the underlying matcher may be interested in the address of the `U` value).
-The code won't compile if any of these conditions isn't met.
+The code won't compile if any of these conditions aren't met.
Here's one example:
diff --git a/googletest/test/gtest_unittest.cc b/googletest/test/gtest_unittest.cc
index 1d3c7c7a..0ae8e035 100644
--- a/googletest/test/gtest_unittest.cc
+++ b/googletest/test/gtest_unittest.cc
@@ -3115,13 +3115,13 @@ TEST(DISABLED_TestCase, DISABLED_TestShouldNotRun) {
FAIL() << "Unexpected failure: Test in disabled test case should not be run.";
}
-// Check that when all tests in a test case are disabled, SetupTestCase() and
+// Check that when all tests in a test case are disabled, SetUpTestCase() and
// TearDownTestCase() are not called.
class DisabledTestsTest : public Test {
protected:
static void SetUpTestCase() {
FAIL() << "Unexpected failure: All tests disabled in test case. "
- "SetupTestCase() should not be called.";
+ "SetUpTestCase() should not be called.";
}
static void TearDownTestCase() {
diff --git a/travis.sh b/travis.sh
index cb36e989..6e7f06ab 100755
--- a/travis.sh
+++ b/travis.sh
@@ -3,12 +3,11 @@ set -evx
env | sort
mkdir build || true
-mkdir build/$GTEST_TARGET || true
-cd build/$GTEST_TARGET
+cd build
cmake -Dgtest_build_samples=ON \
-Dgtest_build_tests=ON \
-Dgmock_build_tests=ON \
-DCMAKE_CXX_FLAGS=$CXX_FLAGS \
- ../../$GTEST_TARGET
+ ..
make
CTEST_OUTPUT_ON_FAILURE=1 make test