aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGennadiy Civil <gennadiycivil@users.noreply.github.com>2018-08-16 13:18:13 -0400
committerGitHub <noreply@github.com>2018-08-16 13:18:13 -0400
commitc38f4b9f2c542d16611b59e37b5e4d2ec0c8f924 (patch)
tree7b3b8b24fd173a16b88036ef1171c135dc298908
parentf3a9fa6a62a29746eba6c7092a2fada2fc1a5e90 (diff)
downloadgoogletest-c38f4b9f2c542d16611b59e37b5e4d2ec0c8f924.tar.gz
googletest-c38f4b9f2c542d16611b59e37b5e4d2ec0c8f924.tar.bz2
googletest-c38f4b9f2c542d16611b59e37b5e4d2ec0c8f924.zip
Small style changes.
Just small style changes and we can accept this PR
-rw-r--r--googletest/src/gtest-port.cc22
1 files changed, 8 insertions, 14 deletions
diff --git a/googletest/src/gtest-port.cc b/googletest/src/gtest-port.cc
index f6bc125c..fecb5d11 100644
--- a/googletest/src/gtest-port.cc
+++ b/googletest/src/gtest-port.cc
@@ -296,8 +296,8 @@ void Mutex::AssertHeld() {
namespace {
-// Use the RAII idiom to flag mem allocs that are intentionally never
-// deallocated. The motivation is to silence the false positive mem leaks
+// Use the RAII idiom to flag mem allocs that are intentionally never
+// deallocated. The motivation is to silence the false positive mem leaks
// that are reported by the debug version of MS's CRT which can only detect
// if an alloc is missing a matching deallocation.
// Example:
@@ -306,24 +306,24 @@ namespace {
//
class MemoryIsNotDeallocated
{
-public:
+ public:
MemoryIsNotDeallocated() : old_crtdbg_flag_(0) {
#ifdef _MSC_VER
old_crtdbg_flag_ = _CrtSetDbgFlag(_CRTDBG_REPORT_FLAG);
// Set heap allocation block type to _IGNORE_BLOCK so that MS debug CRT
// doesn't report mem leak if there's no matching deallocation.
_CrtSetDbgFlag(old_crtdbg_flag_ & ~_CRTDBG_ALLOC_MEM_DF);
-#endif // _MSC_VER
+#endif // _MSC_VER
}
~MemoryIsNotDeallocated() {
#ifdef _MSC_VER
// Restore the original _CRTDBG_ALLOC_MEM_DF flag
_CrtSetDbgFlag(old_crtdbg_flag_);
-#endif // _MSC_VER
+#endif // _MSC_VER
}
-private:
+ private:
int old_crtdbg_flag_;
GTEST_DISALLOW_COPY_AND_ASSIGN_(MemoryIsNotDeallocated);
@@ -584,17 +584,11 @@ class ThreadLocalRegistryImpl {
return 0;
}
- // Return a newly constructed ThreadIdToThreadLocals that's intentionally never deleted
- static ThreadIdToThreadLocals* NewThreadIdToThreadLocals() {
- // Use RAII to flag that following mem alloc is never deallocated.
- MemoryIsNotDeallocated memory_is_not_deallocated;
- return new ThreadIdToThreadLocals;
- }
-
// Returns map of thread local instances.
static ThreadIdToThreadLocals* GetThreadLocalsMapLocked() {
mutex_.AssertHeld();
- static ThreadIdToThreadLocals* map = NewThreadIdToThreadLocals();
+ MemoryIsNotDeallocated memory_is_not_deallocated;
+ static ThreadIdToThreadLocals* map = new ThreadIdToThreadLocals();
return map;
}