diff options
| author | zhanyong.wan <zhanyong.wan@861a406c-534a-0410-8894-cb66d6ee9925> | 2013-06-18 18:44:25 +0000 |
|---|---|---|
| committer | zhanyong.wan <zhanyong.wan@861a406c-534a-0410-8894-cb66d6ee9925> | 2013-06-18 18:44:25 +0000 |
| commit | 48568d0688d6e330ecf2efadd9d1539c349f6167 (patch) | |
| tree | ad1953f0c21fb1ccfd7c5f93f790b777067d79a1 | |
| parent | c506784b08473f3ba8f37d588fd08d8d3f948245 (diff) | |
| download | googletest-48568d0688d6e330ecf2efadd9d1539c349f6167.tar.gz googletest-48568d0688d6e330ecf2efadd9d1539c349f6167.tar.bz2 googletest-48568d0688d6e330ecf2efadd9d1539c349f6167.zip | |
Fixes compatibility with C++11: (1 - 1) is no longer a NULL pointer constant.
| -rw-r--r-- | src/gtest.cc | 6 | ||||
| -rw-r--r-- | test/gtest_unittest.cc | 9 |
2 files changed, 5 insertions, 10 deletions
diff --git a/src/gtest.cc b/src/gtest.cc index 57719aa9..d6552f23 100644 --- a/src/gtest.cc +++ b/src/gtest.cc @@ -182,6 +182,10 @@ bool g_help_flag = false; } // namespace internal +static const char* GetDefaultFilter() { + return kUniversalFilter; +} + GTEST_DEFINE_bool_( also_run_disabled_tests, internal::BoolFromGTestEnv("also_run_disabled_tests", false), @@ -208,7 +212,7 @@ GTEST_DEFINE_string_( GTEST_DEFINE_string_( filter, - internal::StringFromGTestEnv("filter", kUniversalFilter), + internal::StringFromGTestEnv("filter", GetDefaultFilter()), "A colon-separated list of glob (not regex) patterns " "for filtering the tests to run, optionally followed by a " "'-' and a : separated list of negative patterns (tests to " diff --git a/test/gtest_unittest.cc b/test/gtest_unittest.cc index 5aec883b..0cab07d1 100644 --- a/test/gtest_unittest.cc +++ b/test/gtest_unittest.cc @@ -512,15 +512,6 @@ TEST(NullLiteralTest, IsTrueForNullLiterals) { EXPECT_TRUE(GTEST_IS_NULL_LITERAL_(0)); EXPECT_TRUE(GTEST_IS_NULL_LITERAL_(0U)); EXPECT_TRUE(GTEST_IS_NULL_LITERAL_(0L)); - -# ifndef __BORLANDC__ - - // Some compilers may fail to detect some null pointer literals; - // as long as users of the framework don't use such literals, this - // is harmless. - EXPECT_TRUE(GTEST_IS_NULL_LITERAL_(1 - 1)); - -# endif } // Tests that GTEST_IS_NULL_LITERAL_(x) is false when x is not a null |