diff options
| author | Konstantin Đorđević <vomindoraan@gmail.com> | 2020-04-09 01:18:30 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-09 00:18:30 +0100 |
| commit | be2f5816b6cf6513591f825df1d0438729b83388 (patch) | |
| tree | 86d00fbf766521955ab50706b8d109d800e4b052 /tmk_core/common | |
| parent | ff213d5fe1a74f345dd2263c6fb4bc9280f74e0f (diff) | |
| download | firmware-be2f5816b6cf6513591f825df1d0438729b83388.tar.gz firmware-be2f5816b6cf6513591f825df1d0438729b83388.tar.bz2 firmware-be2f5816b6cf6513591f825df1d0438729b83388.zip | |
Fix compile issues related to NO_ACTION_MACRO/FUNCTION and LTO_ENABLE (#8663)
* Define NO_ACTION_MACRO/FUNCTION in header instead of makefile when LTO is enabled
Currently, boards and keymaps that define NO_ACTION_MACRO/FUNCTION unconditionally
will not compile with LTO_ENABLE (#8604). This fixes the issue by moving the
definitions from common.mk to action.h, which enables us to check for previous
definitions of those macros (this cannot be done in a makefile).
* Remove LTO checks in templates
Since now NO_ACTION_MACRO/FUNCTION are defined as needed in action.h (which is
included by quantum.h), checking for LTO in keyboard and user code is no
longer required.
* Update LTO_ENABLE docs
Diffstat (limited to 'tmk_core/common')
| -rw-r--r-- | tmk_core/common/action.h | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/tmk_core/common/action.h b/tmk_core/common/action.h index dd22023f9..c82c9c81b 100644 --- a/tmk_core/common/action.h +++ b/tmk_core/common/action.h @@ -28,6 +28,16 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. extern "C" { #endif +/* Disable macro and function features when LTO is enabled, since they break */ +#ifdef LINK_TIME_OPTIMIZATION_ENABLE +# ifndef NO_ACTION_MACRO +# define NO_ACTION_MACRO +# endif +# ifndef NO_ACTION_FUNCTION +# define NO_ACTION_FUNCTION +# endif +#endif + /* tapping count and state */ typedef struct { bool interrupted : 1; |